Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add l1tPhase2L1CaloEGammaEmulator to the phase 2 L1 event content #44450

Merged

Conversation

epalencia
Copy link
Contributor

This PR adds a new collection to the phase-2 L1 event content.

This PR superseeds #43872.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44450/39520

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @epalencia for master.

It involves the following packages:

  • L1Trigger/Configuration (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@missirol, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@epalencia
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13801c/38222/summary.html
COMMIT: d0a05d1
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44450/38222/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 18-Mar-2024 14:23:20 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 18-Mar-2024 14:23:27 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 18-Mar-2024 14:26:13 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TStreamerInfo::Build
l1tp2::DigitizedClusterCorrelator: ap_uint<64> has no streamer or dictionary, data member "clusterData" will not be saved

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 24034.024034.0_TTbar_14TeV+2026D96/step2_TTbar_14TeV+2026D96.log
  • 20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
  • 23634.023634.0_TTbar_14TeV+2026D95/step2_TTbar_14TeV+2026D95.log
Expand to see more relval errors ...

@aloeliger
Copy link
Contributor

I think @skkwan has a PR open designed to handle this serialization issus: #44390

@aloeliger
Copy link
Contributor

please test with #44390

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13801c/38232/summary.html
COMMIT: d0a05d1
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44450/38232/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 150 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 52 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297369
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297337
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #44390

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4a38e10 into cms-sw:master Mar 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants