Use default op= in LASModuleProfile

[Dr15Jones]

PR description:

This avoids a clang warning about deprecated copy constructor.

PR validation:

Compiling under CMSSW_14_1_CLANG_X_2024-03-18-2300 shows the warnings went away.

[Dr15Jones]

@makortel FYI

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44463/39547

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• Alignment/LaserAlignment (alca)

@perrotta, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@tocheng, @rsreds, @adewit, @mmusich, @yuanchao this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

I wonder why a std::vector is used for data, while a fixed size std::array would have allowed quite some simplification (for example, the method init() would not be needed)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b19803/38253/summary.html
COMMIT: 21833f1
CMSSW: CMSSW_14_1_X_2024-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44463/38253/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 49 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297346
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

• While my comment above still remains, it is actually rather orthogonal to the updates proposed in this PR, which can therefore get signed by alca
• Let me tag @mmusich (as a starting point...) to get feedback about a possible replacement of std::vector with a fixed size std::array for the data vector in LASModuleProfile

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

@perrotta

Let me tag @mmusich (as a starting point...) to get feedback about a possible replacement of std::vector with a fixed size std::array for the data vector in LASModuleProfile

the amount of work that these unmaintained packages generates never ceases to amaze me.
We don't have a (working) laser alignment system since at least the beginning of Run-2 (see LAS review report from 2014 ).
It is perhaps time to think to decommission these packages (even if it implies chasing down dependencies elsewhere).
Tagging @cms-sw/trk-dpg-l2

[antoniovilela]

+1