Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex177 Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8 #44493

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 20, 2024

PR description:

Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8.

PR validation:

Tested with the workflow 29634.0 in runTheMatrix where this scenario is used

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backported to CMSSW version 14_0_X using #44494

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44493/39594

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)

@davidlange6, @sunilUIET, @subirsarkar, @fabiocos, @makortel, @antoniovilela, @cmsbuild, @mdhildreth, @srimanob, @rappoccio, @bsunanda, @AdrianoDee, @Dr15Jones, @civanch, @miquork can you please review it and eventually sign? Thanks.
@felicepantaleo, @VinInn, @Martin-Grunewald, @vargasa, @fabiocos, @sameasy, @rovere, @makortel, @slomeo, @mmusich, @mtosi, @missirol, @dgulhan, @JanFSchulte, @GiacomoSguazzoni, @VourMa this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34b5bc/38305/summary.html
COMMIT: a2540f1
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44493/38305/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

+geometry

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this PR

@bsunanda
Copy link
Contributor Author

@sunilUIET Please approve this PR

@sunilUIET
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

It seems there is unit test failure with the new workflow test in master. Test is on-going, I don't see the detail of failure yet.
I propose to wait until the master PR is merged first.

@civanch
Copy link
Contributor

civanch commented Mar 21, 2024

@srimanob , if you mean #44497 , there is a DAS problem. This PR seems to be clean.

@srimanob
Copy link
Contributor

Hi @civanch
I just wait until the test of #44494 done, and see result.

@srimanob
Copy link
Contributor

@cmsbuild please test workflow 29634.0

Just to complete the test. The master PR is signed already.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34b5bc/38324/summary.html
COMMIT: a2540f1
CMSSW: CMSSW_14_1_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44493/38324/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
13045.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@srimanob
Copy link
Contributor

+Upgrade

New workflow runs fine.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ef52f46 into cms-sw:master Mar 22, 2024
11 checks passed
cmsbuild added a commit that referenced this pull request Mar 25, 2024
Phase2-gex177X Backport #44493 (Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants