Update of Phase-2 GMT Emulator #44498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 20, 2024 13:48
Squash below commits Update Muon DataFormat Add Data and test script Adding new files from Michalis' Remove Node.h The Node class is renamed as TPS Reorganize the header files under plugins The original header files were moved to plugins by central CMSSW. Given the growing code, we think it is better to split header and source files, to keep the code clean. Apply Code format Code Check and Format Add python files Update gmt_cfi file Send TrackerMuon Quality score and isosum Sending quality score and isolation sum to GT Fix bug of the qual score Header Error fix and code formatting L1Trigger/Phase2L1GMT/interface/Constants.h was obsolete and removed. The TPSLUTs.h is used instead. Fix displaced KMTF bug Update DataFormats/L1TMuonPhase2/interface/KMTFTrack.h Co-authored-by: Andrew Loeliger <andrew.loeliger@cern.ch> Update DataFormats/L1TMuonPhase2/interface/KMTFTrack.h Co-authored-by: Andrew Loeliger <andrew.loeliger@cern.ch> Update L1Trigger/Phase2L1GMT/interface/KMTF.h Co-authored-by: Andrew Loeliger <andrew.loeliger@cern.ch> Update L1Trigger/Phase2L1GMT/interface/KMTFCore.h Co-authored-by: Andrew Loeliger <andrew.loeliger@cern.ch> Update L1Trigger/Phase2L1GMT/interface/KMTFLUTs.h Co-authored-by: Andrew Loeliger <andrew.loeliger@cern.ch> Update L1Trigger/Phase2L1GMT/interface/TPS.h Co-authored-by: Andrew Loeliger <andrew.loeliger@cern.ch> Fix comments on DataFormat Work on the comments Move default desctuctor to header files Abstract the prapagation in TPSAlgo Update for CMSSW_14 1. Fix issues when moving to CMSSW_14 release 2. Changed all the printf to edmLogInfo Fix issue from cherry-pick Add Phase-2 OMTF and EMTF to GMT SA - Get the Phase 2 prompt and displaced OMTF and EMTF to GMT SA - Add Phase 2 OMTF, EMTF, GMT to L1 Update apQual to apQualFlag as requested by GT
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44498/39609
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44498/39610
|
|
A new Pull Request was created by @zhenbinwu for master. It involves the following packages:
@epalencia, @subirsarkar, @aloeliger, @srimanob, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44498/39622
|
|
Pull request #44498 was updated. @subirsarkar, @cmsbuild, @epalencia, @srimanob, @aloeliger can you please check and sign again. |
|
+1 Size: This PR adds an extra 920KB to repository
Comparison SummarySummary:
|
|
ping @cms-sw/upgrade-l2 , @cms-sw/dqm-l2 |
|
Hi @zhenbinwu @epalencia |
Thanks for your comment. The There are some variables defined in the code but not used in the code yet. I would prefer to keep them there for clarification. Thanks! |
|
+Upgrade |
|
ping @cms-sw/dqm-l2, could you please review this PR? |
|
+1
|
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This was referenced Jul 15, 2024
|
This PR added bunch of compilation warnings such as and These were visible also in the PR tests, e.g. in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f13131/40267/build-logs/ . @smuzaffar Don't we report compilation warnings in the PR test summary message (#44498 (comment))? |
yes , bot should have reported it. I have asked @iarspider to look in to bot code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Major update of the Phase-2 GMT Emulator:
PR validation:
Validated by L1 menu team