Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable workflow 180.1 #44540

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Disable workflow 180.1 #44540

merged 1 commit into from
Mar 26, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR removes workflow 180.1 which currently fails in IBs (see comment). I will add it back in a future PR once I update the STARlight gridpack.

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44540/39673

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@subirsarkar, @srimanob, @miquork, @cmsbuild, @AdrianoDee, @sunilUIET can you please review it and eventually sign? Thanks.
@fabiocos, @Martin-Grunewald, @missirol, @makortel, @slomeo this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel makortel mentioned this pull request Mar 25, 2024
@AdrianoDee
Copy link
Contributor

type bug-fix

@AdrianoDee
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcf5e1/38402/summary.html
COMMIT: b8fc159
CMSSW: CMSSW_14_1_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44540/38402/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297537
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297514
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

Why would this change be a bug-fix? Seems a bug coverup perhaps...

@stahlleiton
Copy link
Contributor Author

stahlleiton commented Mar 26, 2024

Why would this change be a bug-fix? Seems a bug coverup perhaps...

There is indeed an issue with the gridpack used, which should get resolved after I update it (I am currently running some tests).
So technically this PR is not a bug fix, but rather disables the problematic test for the time being to avoid failures in IBs.

@AdrianoDee
Copy link
Contributor

I don't think have bug-coverup in the labels.

@antoniovilela
Copy link
Contributor

@stahlleiton
Andre, we will approve, but we do not like having commented out code in the release. Usually one would remove the line, meaning removing the workflow and then add it back once it works.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a2bb0c7 into cms-sw:master Mar 26, 2024
11 checks passed
@stahlleiton
Copy link
Contributor Author

@stahlleiton
Andre, we will approve, but we do not like having commented out code in the release. Usually one would remove the line, meaning removing the workflow and then add it back once it works.

Noted. Thanks for the feedback. I will avoid commenting out lines next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants