Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CepGenInterface: Added missing include #44647

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

forthommel
Copy link
Contributor

PR description:

This PR fixes the build of CepGen release >= 1.2.2 where the include chain was strongly modified. This should cure the recent build failure encountered in cms-sw/cmsdist#9122.

PR validation:

Builds

FYI: @smuzaffar, @bbilin

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44647/39843

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

A new Pull Request was created by @forthommel for master.

It involves the following packages:

  • GeneratorInterface/CepGenInterface (generators)

@SiewYan, @bbilin, @menglu21, @mkirsano, @cmsbuild, @alberto-sanchez, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@bbilin
Copy link
Contributor

bbilin commented Apr 6, 2024

@cmsbuild please test with cms-sw/cmsdist#9122

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecd7ad/38655/summary.html
COMMIT: 70190a0
CMSSW: CMSSW_14_1_X_2024-04-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44647/38655/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecd7ad/38655/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecd7ad/38655/git-merge-result

Comparison Summary

Summary:

  • You potentially added 19 lines to the logs
  • Reco comparison results: 43 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3307717
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307691
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@forthommel
Copy link
Contributor Author

Fantastic! I will then launch the two backports!

@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmsdist#9122, please check if they should be merged together

@forthommel
Copy link
Contributor Author

@rappoccio, @sextonkennedy, @antoniovilela: they should! :-)

@antoniovilela
Copy link
Contributor

@rappoccio, @sextonkennedy, @antoniovilela: they should! :-)

Laurent, it is worthless to ping us with our user names. Please use @cms-sw/orp-l2.

@antoniovilela
Copy link
Contributor

@cms-sw/generators-l2
Please sign the master PR before the backports.
Better yet is to sign the backports after the master has passed an IB.

@forthommel
Copy link
Contributor Author

forthommel commented Apr 15, 2024

Thanks for the information, Antonio. I'll use @cms-sw/orp-l2 in the future, then.
Although GitHub does not highlight it for me (possibly because I am not part of the cms-sw organisation), so I suspect it does not trigger a ping.

@antoniovilela
Copy link
Contributor

Thanks for the information, Antonio. I'll use @cms-sw/orp-l2 in the future, then. Although GitHub does not highlight it for me (possibly because I am not part of the cms-sw organisation), so I suspect it does not trigger a ping.

We can filter mentions to @cms-sw/orp-l2. At least 1-2 times per day I will look for it.
We get flooded with notifications to our user names.

@antoniovilela
Copy link
Contributor

@cms-sw/generators-l2 Please sign the master PR before the backports. Better yet is to sign the backports after the master has passed an IB.

@cms-sw/generators-l2
Please sign the master PR.

@forthommel
Copy link
Contributor Author

@cms-sw/generators-l2 do not seem to be monitoring their notifications as consciously as you do :) Possibly a CMS week effect too!

@bbilin
Copy link
Contributor

bbilin commented Apr 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9122

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 28b1c52 into cms-sw:master Apr 19, 2024
11 checks passed
@forthommel forthommel deleted the cepgen_patch-14_1_X branch April 19, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants