-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CepGenInterface: Added missing include #44647
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44647/39843
|
A new Pull Request was created by @forthommel for master. It involves the following packages:
@SiewYan, @bbilin, @menglu21, @mkirsano, @cmsbuild, @alberto-sanchez, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test with cms-sw/cmsdist#9122 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecd7ad/38655/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
Fantastic! I will then launch the two backports! |
REMINDER @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with cms-sw/cmsdist#9122, please check if they should be merged together |
@rappoccio, @sextonkennedy, @antoniovilela: they should! :-) |
Laurent, it is worthless to ping us with our user names. Please use @cms-sw/orp-l2. |
@cms-sw/generators-l2 |
Thanks for the information, Antonio. I'll use @cms-sw/orp-l2 in the future, then. |
We can filter mentions to @cms-sw/orp-l2. At least 1-2 times per day I will look for it. |
@cms-sw/generators-l2 |
@cms-sw/generators-l2 do not seem to be monitoring their notifications as consciously as you do :) Possibly a CMS week effect too! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR fixes the build of CepGen release >= 1.2.2 where the include chain was strongly modified. This should cure the recent build failure encountered in cms-sw/cmsdist#9122.
PR validation:
Builds
FYI: @smuzaffar, @bbilin