Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] modified for Phase2 DeepJet retraining model #44756

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 17, 2024

backport of #44431

PR description:

The BTV@HLT group has a Phase2 DeepJet retrained model.
The target for this retraining is to retrain DeepJet and recreate/Improve TDR performance.
The retraining online performance is compared to the TDR/offline model. Please see the details here and here.
This PR is associated with the Phase2 DeepJet retraining model integration cms-sw/cmsdist#9140

PR validation:

The model was tested locally in CMSSW_13_1_0.
Follow the Phase 2 HLT simplified menu and edmConfigDump to get the configuration file and the HLT dump phase2_hlt.py, and in process.hltPfDeepFlavourJetTagsModEta2p4 and
process.hltPfDeepFlavourJetTags, change the model_path to retained model.
Please see the details in the presentation.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44431 for 2024 phase-2 HLT production

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@mmusich, @cmsbuild, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@rovere, @SohamBhattacharya, @missirol, @Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2024

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2024

@cmsbuild please test

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2024

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2d5b4/38885/summary.html
COMMIT: 51cefb5
CMSSW: CMSSW_14_0_X_2024-04-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44756/38885/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3318804
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3318778
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Apr 17, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#9140

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bade0e7 into cms-sw:CMSSW_14_0_X Apr 18, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_phase_bretrained_hlt_14_0_X branch April 18, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants