[MTD] Mtd association maps: remove energy selection for ETL clusters

[martinamalberti]

PR description:

This pull requests updates MtdAssociationMaps by removing the selection on the energy ratio between the reco cluster and MtdSimLayerCluster for ETL clusters. This follows from the ETL digitization model update of PR #43762.

PR validation:

The code compiles and runs.
It was validated on a RelValSinglePiFlatPt0p7To10 sample. The efficiency of reco-sim cluster association is recovered.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44818/40064

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @martinamalberti for master.

It involves the following packages:

• SimFastTiming/MtdAssociatorProducers (upgrade, simulation)

@cmsbuild, @srimanob, @mdhildreth, @subirsarkar, @civanch can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c18baf/39036/summary.html
COMMIT: 690c3c8
CMSSW: CMSSW_14_1_X_2024-04-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44818/39036/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
25088.203 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 85 lines to the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 87
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319745
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[martinamalberti]

Changes in DQM ETL Local Reco plots are as expected.

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c18baf/39036/summary.html COMMIT: 690c3c8 CMSSW: CMSSW_14_1_X_2024-04-23-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44818/39036/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline: 25088.203 step 3 The results for the comparisons for these workflows could be incomplete This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 85 lines to the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 87
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319745
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1