-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The module label for raw data was long ago changed from "source" to "raw... #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rawDataCollector", in order to be consistent with the simulation. However, many files in EventFilter/*RawToDigi still use the old, obsolete, and incorrect label "source", which cannot work, even for reading old data. This means that each of these files is either unused, or the configuration is modified elsewhere to use "rawDataCollector". This tagset fixes this bug for all EventFilter/*RawToDigi packages owned by reco. Use of the obsolete label "source' is an impediment to implementing an urgent new feature to use the datamixer to mix premixed pileup stored as raw data. All relvals passed in the latest 6_2_X IB with this tagset. I urge picking it up in 6_2_X. It is a bug fix. --- Tagset history --- 2013-06-07 15:20:15 - Queued by wmtan. 2013-06-10 17:37:02 - Signed (all signatures provided) by speer. 2013-07-03 20:34:56 - Approved by davidlt.
ktf
added a commit
that referenced
this pull request
Jul 5, 2013
The module label for raw data was long ago changed from "source" to "raw...
nclopezo
pushed a commit
to nclopezo/cmssw
that referenced
this pull request
May 5, 2014
It loos for static checks results in both slc5 and slc6
franzoni
pushed a commit
to franzoni/cmssw
that referenced
this pull request
May 8, 2014
Fixing analysis case when loading js from wmstats couchapp
arizzi
added a commit
to arizzi/cmssw
that referenced
this pull request
Apr 2, 2015
Dev jec phys14v4
gdimperi
pushed a commit
to gdimperi/cmssw
that referenced
this pull request
Jun 21, 2015
…ultiPdf-support Nckw roo add pdf roo multi pdf support
degrutto
pushed a commit
to degrutto/cmssw
that referenced
this pull request
Sep 13, 2015
Thanks Andrea, and sorry for the late merge.
mbluj
pushed a commit
to mbluj/cmssw
that referenced
this pull request
Apr 28, 2017
Modified Cone-based Tau Builder (90X)
mariadalfonso
pushed a commit
to mariadalfonso/cmssw
that referenced
this pull request
May 6, 2017
amartelli
pushed a commit
to amartelli/cmssw
that referenced
this pull request
Apr 16, 2019
Add BDT cut on sublead lep
BrieucF
pushed a commit
to BrieucF/cmssw
that referenced
this pull request
Jul 15, 2019
Minor change in minNumberOfHits
dsrankin
pushed a commit
to dsrankin/cmssw
that referenced
this pull request
Mar 9, 2022
Improved integration scripts & plot style
jchismar
pushed a commit
to jchismar/cmssw
that referenced
this pull request
Jul 3, 2024
…T_X_LSTCore_realfiles_TrackLooperPR404 Add Occupancy Branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...DataCollector", in order to be consistent with the simulation. However,
many files in EventFilter/_RawToDigi still use the old, obsolete, and incorrect label "source", which cannot work, even for reading old data. This means that each of these files is either unused, or the configuration is modified elsewhere to use "rawDataCollector".
This tagset fixes this bug for all EventFilter/_RawToDigi packages owned by reco.
Use of the obsolete label "source' is an impediment to implementing an urgent new feature to use the datamixer to mix premixed pileup stored as raw data.
All relvals passed in the latest 6_2_X IB with this tagset.
I urge picking it up in 6_2_X. It is a bug fix.
--- Tagset history ---
2013-06-07 15:20:15 - Queued by wmtan.
2013-06-10 17:37:02 - Signed (all signatures provided) by speer.
2013-07-03 20:34:56 - Approved by davidlt.