Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configuration of ZDC inputs in L1REPACK:uGT #45236

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

missirol
Copy link
Contributor

PR description:

L1REPACK:uGT does not seem to work in 14_1_X, probably since the integration of #44019 (this was somewhat anticipated in the review of the latter, #44019 (comment)).

This PR is a minimal fix. Merely technical. No changes expected.

FYI: @eyigitba

PR validation:

The following test command works in 14_1_X with this PR, and fails (in 14_1_X) without it.

#!/bin/bash -ex

hltGetConfiguration /dev/CMSSW_14_0_0/GRun \
  --globaltag auto:phase1_2024_realistic \
  --mc \
  --unprescale \
  --output minimal \
  --max-events 100 \
  --input /store/mc/Run3Winter24Digi/TT_TuneCP5_13p6TeV_powheg-pythia8/GEN-SIM-RAW/133X_mcRun3_2024_realistic_v8-v2/80000/dc984f7f-2e54-48c4-8950-5daa848b6db9.root \
  --eras Run3 --l1-emulator uGT --l1 L1Menu_Collisions2024_v1_2_0_xml \
  > hlt.py

cmsRun hlt.py &> hlt.log

For the record, this is the runtime error pre-PR.

----- Begin Fatal Exception 16-Jun-2024 23:23:50 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 20081 event: 14772855 stream: 1
   [1] Running path 'HLTAnalyzerEndpath'
   [2] Prefetching for module L1TRawToDigi/'hltGtStage2Digis'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Calling method for module L1TDigiToRaw/'packGtStage2'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: BXVector<l1t::EtSum>
Looking for module label: simCaloStage2Digis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45236/40613

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@rappoccio, @cmsbuild, @fabiocos, @antoniovilela, @davidlange6 can you please review it and eventually sign? Thanks.
@VinInn, @GiacomoSguazzoni, @sameasy, @makortel, @fabiocos, @slomeo, @mmusich, @mtosi, @dgulhan, @Martin-Grunewald, @JanFSchulte, @rovere, @felicepantaleo, @VourMa this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 17, 2024

@cmsbuild, please test

@eyigitba
Copy link
Contributor

Thanks @missirol ! It's probably my fault to not request this check from the developers in the original PR :)

@Martin-Grunewald
Copy link
Contributor

Presumably this needs a 14_0 backport!

@mmusich
Copy link
Contributor

mmusich commented Jun 17, 2024

Presumably this needs a 14_0 backport!

does it? #44019 wasn't backported?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b90f1a/39919/summary.html
COMMIT: 50ec2ee
CMSSW: CMSSW_14_1_X_2024-06-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45236/39919/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344992
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 7acf42a into cms-sw:master Jun 27, 2024
11 checks passed
@missirol missirol deleted the devel_l1repack_zdc_fix branch June 29, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants