Update heavy-ion eras for 2024 + add MC RelVal workflows #45307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
test parameters:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45307/40717
|
|
A new Pull Request was created by @mandrenguyen for master. It involves the following packages:
@srimanob, @subirsarkar, @aloeliger, @civanch, @rappoccio, @fabiocos, @davidlange6, @kskovpen, @mdhildreth, @miquork, @cmsbuild, @AdrianoDee, @sunilUIET, @antoniovilela, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Unit TestsI found 4 errors in the following unit tests: ---> test test_MC_22_crosscheck had ERRORS ---> test test_MC_23_crosscheck had ERRORS ---> test test_MC_22_setup had ERRORS and more ... RelValsExpand to see more relval errors ...
RelVals-INPUT
Expand to see more relval errors ...
AddOn TestsExpand to see more addon errors ...
|
|
please test |
this issue was caused by a severely broken IB |
This was referenced Jul 3, 2024
|
ping @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 |
|
+Upgrade |
|
@cmsbuild please test Retrigger the test after 2 weeks, before merging. |
|
+1 Size: This PR adds an extra 12KB to repository
Comparison SummarySummary:
|
|
+pdmv |
This was referenced Jul 10, 2024
|
+1 |
cmsbuild
added
operations-approved
fully-signed
orp-approved
and removed
operations-pending
pending-signatures
orp-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
mmusich
reviewed
Nov 2, 2024
| from Configuration.Eras.Era_Run3_2024_cff import Run3_2024 | ||
| from Configuration.ProcessModifiers.pp_on_AA_cff import pp_on_AA | ||
| from Configuration.ProcessModifiers.approxSiStripClusters_cff import approxSiStripClusters | ||
| from Configuration.Eras.Modifier_pp_on_PbPb_run3_cff import pp_on_PbPb_run3 |
There was a problem hiding this comment.
for my education is there a reason why this is using pp_on_PbPb_run3 as opposed to pp_on_PbPb_run3_2024 (used in Configuration/Eras/python/Era_Run3_pp_on_PbPb_2024_cff.py)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up heavy-ion eras for 2024:
pp_on_PbPbtype eras and their corresponding MC relval workflows (161,161.2,161.02, etc)Run3_2024, rather than justRun3, although I think for the moment they're equivalentNote that certain sim customizations for the ZDC and HF fine-grained bit are for now just copied from the 2023 era. They are extended to the UPC era, although this era is so far only used for the reco step, not for the digi one. In case the UPC era is used for digi at some point, it's better to change this now.
The heavy-ion embedding (event overlay) workflows are not extended to 2024 yet. This will be done in a subsequent PR.
No backport will be needed.