Phase2-hgx358C Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal #45366

bsunanda · 2024-07-03T07:05:40Z

PR description:

Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal

PR validation:

Use the runTheMatrix test workflow

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

…r the future V19 version of HGCal

cmsbuild · 2024-07-03T07:06:05Z

cms-bot internal usage

cmsbuild · 2024-07-03T07:11:23Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40790

This PR adds an extra 92KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40790/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40790/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-07-03T07:17:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40791

This PR adds an extra 92KB to repository

cmsbuild · 2024-07-03T07:17:48Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)
Geometry/HGCalGeometry (geometry, upgrade)
SimCalorimetry/HGCalSimAlgos (simulation, upgrade)
SimG4CMS/Calo (simulation)
Validation/HGCalValidation (dqm)

@Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @makortel, @mdhildreth, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @cseez, @fabiocos, @felicepantaleo, @hatakeyamak, @lecriste, @lgray, @martinamalberti, @missirol, @pfs, @rovere, @sameasy, @sethzenz, @slomeo, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2024-07-03T08:03:39Z

@cmsbuild Please test

cmsbuild · 2024-07-03T09:12:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45366/40793

This PR adds an extra 96KB to repository

cmsbuild · 2024-07-03T14:17:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21ee98/40197/summary.html
COMMIT: 0f76b00
CMSSW: CMSSW_14_1_X_2024-07-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45366/40197/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 6 lines to the logs
Reco comparison results: 4047 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345088
DQMHistoTests: Total failures: 5390
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3339678
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 2 / 46 workflows

civanch · 2024-07-03T15:05:48Z

+1

srimanob · 2024-07-08T21:08:22Z

+Upgrade

srimanob · 2024-07-08T21:08:55Z

Note for the next PR:

src/SimCalorimetry/HGCalSimAlgos/src/HGCalSciNoiseMap.cc:167:10: warning: Value stored to 'edge' during its initialization is never read [deadcode.DeadStores]
  167 |   double edge(refEdge_);  //start with reference 3cm of edge

bsunanda · 2024-07-12T04:15:39Z

@nothingface0, @rvenditti, @syuvivida, @tjavaid Please approve this PR

bsunanda · 2024-07-13T15:23:36Z

@nothingface0, @rvenditti, @syuvivida, @tjavaid Please approve this PR

bsunanda · 2024-07-15T10:10:57Z

@tjavaid Please approve this PR

tjavaid · 2024-07-16T12:27:02Z

+1

cmsbuild · 2024-07-16T12:27:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2024-07-16T15:19:56Z

+1

fwyzard · 2024-08-23T10:30:13Z

Geometry/HGCalGeometry/src/HGCalGeometry.cc

@@ -233,7 +237,7 @@ GlobalPoint HGCalGeometry::getPosition(const DetId& detid, bool debug) const {
                                        << id.iCell2;
      }
      xy = m_topology.dddConstants().locateCell(
-          id.zSide, id.iLay, id.iSec1, id.iSec2, id.iCell1, id.iCell2, true, true, false, debug);
+          id.zSide, id.iLay, id.iSec1, id.iSec2, id.iCell1, id.iCell2, true, true, true, cog, debug);


@bsunanda was it intended to flip the norot value from false to true, while adding the cog parameter ?

Unfortunately the summary and comparisons of the test are not there any more.
@bsunanda , did you have a look at the 4047 differences found?

Add afew new modes to enable cog computation for wafers as default fo…

69c5983

…r the future V19 version of HGCal

cmsbuild added this to the CMSSW_14_1_X milestone Jul 3, 2024

cmsbuild added simulation-pending dqm-pending geometry-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Jul 3, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 3, 2024

Code check

483ec27

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 3, 2024

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2024

Improve the u,v to x,y conversion for partial wafers

0f76b00

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Jul 3, 2024

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2024

cmsbuild added tests-approved and removed tests-started labels Jul 3, 2024

cmsbuild added geometry-approved simulation-approved and removed simulation-pending geometry-pending labels Jul 3, 2024

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 8, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 16, 2024

cmsbuild added orp-approved and removed orp-pending labels Jul 16, 2024

cmsbuild merged commit 59bdefa into cms-sw:master Jul 16, 2024
11 checks passed

makortel mentioned this pull request Jul 19, 2024

Added TestSourceProcessor helper #45443

Merged

fwyzard reviewed Aug 23, 2024

View reviewed changes

waredjeb mentioned this pull request Aug 23, 2024

Fix HGCAL Geometry - Revert norot back to False in locateCell() #45782

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx358C Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal #45366

Phase2-hgx358C Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal #45366

bsunanda commented Jul 3, 2024

cmsbuild commented Jul 3, 2024 •

edited

Loading

cmsbuild commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

bsunanda commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

civanch commented Jul 3, 2024

srimanob commented Jul 8, 2024

srimanob commented Jul 8, 2024

bsunanda commented Jul 12, 2024

bsunanda commented Jul 13, 2024

bsunanda commented Jul 15, 2024

tjavaid commented Jul 16, 2024

cmsbuild commented Jul 16, 2024

rappoccio commented Jul 16, 2024

fwyzard Aug 23, 2024

felicepantaleo Aug 23, 2024

Phase2-hgx358C Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal #45366

Phase2-hgx358C Add a few new modes to enable cog computation for wafers as default for the future V19 version of HGCal #45366

Conversation

bsunanda commented Jul 3, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jul 3, 2024 • edited Loading

cmsbuild commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

bsunanda commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

cmsbuild commented Jul 3, 2024

Comparison Summary

civanch commented Jul 3, 2024

srimanob commented Jul 8, 2024

srimanob commented Jul 8, 2024

bsunanda commented Jul 12, 2024

bsunanda commented Jul 13, 2024

bsunanda commented Jul 15, 2024

tjavaid commented Jul 16, 2024

cmsbuild commented Jul 16, 2024

rappoccio commented Jul 16, 2024

fwyzard Aug 23, 2024

Choose a reason for hiding this comment

felicepantaleo Aug 23, 2024

Choose a reason for hiding this comment

cmsbuild commented Jul 3, 2024 •

edited

Loading