-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BTV, NanoAOD] Add UParT discriminants for strange-jet tagging #45684
[BTV, NanoAOD] Add UParT discriminants for strange-jet tagging #45684
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45684/41240 |
A new Pull Request was created by @nurfikri89 for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 52KB to repository Comparison SummarySummary:
|
nurfikri89 is there some documentation of the performance you can add to the PR description? |
enable nano |
There are some differences in the comparisons that are not obviously expected for me. |
@mandrenguyen I have added a link to the DP-note which documents the performance of UParT.
Hmm it is not clear to me also. I will try to take a look at them with a local test on lxplus. |
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
hold |
Pull request has been put on hold by @mandrenguyen |
@mandrenguyen I think it's not a real difference, just that the order of variables in the nano flat table changed because of the new variables? |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR defines the UParT discriminants for strange jet tagging (
SvsUDG
,SvsCB
) and store them in NanoAOD (and JMENano) for AK4 jets. The sum of u, d and g raw scores (UDG
) is also stored, which can be used to re-calculate the raw scores. These new branches are for the NanoAODv15 campaign.The UParT strange jet tagging performance is documented in a recently released DP-note (CMS-DP-2024-066 Figure 4)
PR validation:
runTheMatrix.py -l limited -i all --ibeos
141.044_RunJetMET2023D
and had checked that the new discriminants and scores are in MiniAOD and NanoAOD