Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] BeamSpotOnlineProducer: add more printouts in case of invalid errors #45740

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 18, 2024

backport of #45679

PR description:

Yet another follow-up to #45555. As discussed with the beam spot team, this PR adds an additional level of printout when the algorithm fails to find a valid beamspot from the BeamSpotTransientObjectsRcd and falls back to the DB-stored PCL value, in the case that the input errors are not valid (should never be the case, but since it got logged (see #45555) it would be good to explicitly verify when it happens.
I profit of the PR to remove a couple of magic numbers for the beamspot covariance matrix size.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #45679 for 2024 online data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • RecoVertex/BeamSpotProducer (alca, reconstruction)

@cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @fabiocos, @francescobrivio, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 18, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0374d5/41003/summary.html
COMMIT: 5803265
CMSSW: CMSSW_14_0_X_2024-08-18-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45740/41003/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit af2d35b into cms-sw:CMSSW_14_0_X Aug 20, 2024
9 checks passed
@mmusich mmusich deleted the mm_dev_morePrintOut_BeamSpotOnlineProducer_14_0_X branch August 20, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants