Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change tune names for auto-bkg production #45755

Merged
merged 1 commit into from
Sep 6, 2024
Merged

change tune names for auto-bkg production #45755

merged 1 commit into from
Sep 6, 2024

Conversation

sihyunjeon
Copy link
Contributor

@sihyunjeon sihyunjeon commented Aug 20, 2024 •
edited
Loading

PR description:

Nothing changes except the names for underlying event tune variations, e.g. changing CP5TuneUp to CP5Up.

Continuation of two previous old PRs
#38502
#38358

PR validation:

I don't think there is any runthematrix/relval relevant tests available in the list [1] (there is no CP5Up or CP5Down in the workflows).
[1] https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_extendedgen.py

Later once we have 22 & 23 rereco campaigns and 24 production campaign fully set up, it needs to be backported.

@agrohsje @Cvico @sunilUIET @menglu21 @lviliani @bbilin @DickyChant

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 20, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 20, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45755/41461

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sihyunjeon for master.

It involves the following packages:

  • Configuration/Generator (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@menglu21
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed73e6/41087/summary.html
COMMIT: fbbee3c
CMSSW: CMSSW_14_1_X_2024-08-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45755/41087/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2024.008052024.00805_RunParkingDoubleMuonLowMass02024B_500k/step1_dasquery.log
  • 2024.00712024.0071_RunNoBPTX2024B_1M/step1_dasquery.log
  • 2024.009052024.00905_RunParkingHH2024B_500k/step1_dasquery.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328166
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328143
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@antoniovilela
Copy link
Contributor

ping (to make bot change milestone)

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Sep 3, 2024
@lviliani
Copy link
Contributor

lviliani commented Sep 4, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ed73e6/41286/summary.html
COMMIT: fbbee3c
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45755/41286/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 79 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328501
  • DQMHistoTests: Total failures: 4597
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3323884
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@lviliani
Copy link
Contributor

lviliani commented Sep 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 50faecb into cms-sw:master Sep 6, 2024
11 checks passed
@cmsbuild cmsbuild mentioned this pull request Sep 7, 2024
Merged
@sihyunjeon sihyunjeon deleted the 20240820_tune_renames branch September 24, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_2_X
Development

Successfully merging this pull request may close these issues.
6 participants
@sihyunjeon @cmsbuild @menglu21 @antoniovilela @lviliani @mandrenguyen