Skip non-leaf GeomDets when dumping fireworks geometry

[Dr15Jones]

PR description:

This is an attempt to fix the problem seen trying to dump the phase2 geometry from CMSSW_14_1_0_pre6.

PR validation:

I ran

cmsRun $CMSSW_RELEASE_BASE/src/Fireworks/Geometry/python/dumpRecoGeometry_cfg.py tag=2026 version=D110

and it finished successfully.

[cmsbuild]

cms-bot internal usage

[Dr15Jones]

please test

[mmusich]

please test with #45328

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45784/41513

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• Fireworks/Geometry (visualization)

@Dr15Jones, @alja, @makortel can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-047284/41100/summary.html
COMMIT: fb01256
CMSSW: CMSSW_14_1_X_2024-08-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45784/41100/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_dumpRecoGeometry had ERRORS

RelVals-INPUT

• 2024.4130052024.413005_RunTau2024F_50k/step1_dasquery.log
• 2024.3110052024.311005_RunParkingSingleMuon02024E_50k/step1_dasquery.log
• 2024.311052024.31105_RunParkingSingleMuon02024E_500k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.40505
• 2024.4051
• 2024.41105
• 2024.4111
• 2024.41305
• 2024.311005
• 2024.413005
• 2024.31105
• 2024.40505
• 2024.4051
• 2024.41105
• 2024.4111
• 2024.41305

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3328202
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3328173
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[cmsbuild]

REMINDER @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela: This PR was tested with #45328, please check if they should be merged together

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #45328

[cmsbuild]

REMINDER @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy: This PR was tested with #45328, please check if they should be merged together

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[mandrenguyen]

+1
Merging together with #45328

[mandrenguyen]

ignore tests-rejected with ib-failure