-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for SiPhase2OTFakeLorentzAngleESSource
#45810
add unit tests for SiPhase2OTFakeLorentzAngleESSource
#45810
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45810/41547 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @consuegs, @perrotta, @saumyaphor4252, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+Upgrade No change is expected as the PR only adds unit test. |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #45730 made me realize that we lack dedicated unit tests for
SiPhase2OTFakeLorentzAngleESSource
. This PR adds them as part oftest_CondToolsSiPhase2Tracker
.PR validation:
scram b runtests_test_CondToolsSiPhase2Tracker
runs fine with this branch.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A