Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TauHLT] Add Phase2 MuTau HLT #45976

Merged

Conversation

youngwan-kim
Copy link
Contributor

@youngwan-kim youngwan-kim commented Sep 11, 2024

PR description:

This PR adds a Phase2 MuTau HLT menu with proper P2L1 seeds.
Relevant JIRA ticket : CMSHLT-3009
Relevant presentations :

PR validation:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45976/41735

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @youngwan-kim for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VourMa, @argiro, @missirol, @mmusich, @rchatter, @rovere, @silviodonato, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Copy link
Contributor

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole PR needs to be rebased on top of the changes at 0183839

@mmusich
Copy link
Contributor

mmusich commented Sep 11, 2024

-hlt

@youngwan-kim youngwan-kim force-pushed the Phase2TauHLT_MuTauDev_CMSSW_14_2_X branch from a62f79a to 7ba44fd Compare September 11, 2024 15:41
@cmsbuild
Copy link
Contributor

This PR contains too many commits (368 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45976/41743

@cmsbuild
Copy link
Contributor

Pull request #45976 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 11, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45976 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97e42a/41519/summary.html
COMMIT: c4ae3ae
CMSSW: CMSSW_14_2_X_2024-09-15-0000/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45976/41519/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3331158
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3331132
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Sep 15, 2024

HLT P2 Timing: chart

for the record, due to this PR, the phase-2 HLT timing is up to 5632.6 ms from 5533.2 ms (or +1.8% relative increase)

@mmusich
Copy link
Contributor

mmusich commented Sep 16, 2024

@rovere @VourMa please let me know if you have comments on this PR (an if the timing increase as posted above is reasonable in your opinion). Otherwise I think we're ready to sign.

@mmusich
Copy link
Contributor

mmusich commented Sep 17, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Sep 17, 2024

type tau

@cmsbuild cmsbuild added the tau label Sep 17, 2024
@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants