Add 2024 HI eras to reco processing configuation #45981

mandrenguyen · 2024-09-11T17:27:06Z

PR description:

New HI eras for this year's data taking run have to be included in Prompt reco configs run at the T0

PR validation:

compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

will have to be backported to 14_0_X

cmsbuild · 2024-09-11T17:27:33Z

cms-bot internal usage

cmsbuild · 2024-09-11T17:28:46Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45981/41745

cmsbuild · 2024-09-11T17:29:12Z

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

Configuration/DataProcessing (operations)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mandrenguyen · 2024-09-11T17:29:32Z

please test

cmsbuild · 2024-09-11T20:39:54Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d033ce/41461/summary.html
COMMIT: cbbc24f
CMSSW: CMSSW_14_2_X_2024-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45981/41461/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 177 lines from the logs
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331158
DQMHistoTests: Total failures: 1276
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3329862
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-09-11T20:46:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45981/41747

cmsbuild · 2024-09-11T20:46:47Z

Pull request #45981 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again.

cmsbuild · 2024-09-12T00:00:04Z

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d033ce/41464/summary.html
COMMIT: ff2d67d
CMSSW: CMSSW_14_2_X_2024-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45981/41464/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log
2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log
2024.001001DAS Error

Expand to see more relval errors ...

2024.100001

Comparison Summary

Summary:

You potentially removed 175 lines from the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331158
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3331127
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-09-12T05:34:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45981/41749

cmsbuild · 2024-09-12T05:34:48Z

Pull request #45981 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please check and sign again.

mandrenguyen · 2024-09-12T05:38:40Z

please test

cmsbuild · 2024-09-12T10:14:03Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d033ce/41466/summary.html
COMMIT: c12ee11
CMSSW: CMSSW_14_2_X_2024-09-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45981/41466/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 176 lines from the logs
Reco comparison results: 104 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331158
DQMHistoTests: Total failures: 2852
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3328286
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

mandrenguyen · 2024-09-12T10:17:51Z

+1

cmsbuild · 2024-09-12T10:18:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

mmusich · 2024-10-02T07:18:06Z

Configuration/DataProcessing/python/Impl/ppEra_Run3_2024_UPC.py

+    def __init__(self):
+        pp.__init__(self)
+        self.recoSeq=''
+        self.cbSc='pp'


@mandrenguyen, IIUC the datasets that now you would be processing with this scenario are the ones that last year were processed with hiForwardScenario = "ppEra_Run3_2023_repacked".
That scenario has

cmssw/Configuration/DataProcessing/python/Impl/ppEra_Run3_2023_repacked.py

Line 23 in 2647f99

self.isRepacked=True

why is it not implemented here?

ah, yes, thanks for spotting it.
I guess that's in relation to this failure right? :
#46186 (comment)
Will fix.

fix is here: #46194

mandrenguyen added 2 commits September 11, 2024 19:24

Update reco processing config with 2024 HI eras

f7ea571

add new files

cbbc24f

cmsbuild added this to the CMSSW_14_2_X milestone Sep 11, 2024

cmsbuild added operations-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 11, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 11, 2024

This was referenced Sep 11, 2024

[14_1_X] Add 2024 HI eras to reco processing configuation #45982

Closed

[14_1_X] Add 2024 HI eras to reco processing configuation #45983

Closed

cmsbuild added tests-approved and removed tests-started labels Sep 11, 2024

added new era to run_CfgTest_5.sh

ff2d67d

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Sep 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 11, 2024

cmsbuild added tests-rejected and removed tests-started labels Sep 12, 2024

add 2024 pp ref

c12ee11

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Sep 12, 2024

cmsbuild removed the code-checks-pending label Sep 12, 2024

cmsbuild added the code-checks-approved label Sep 12, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 12, 2024

cmsbuild added tests-approved and removed tests-started labels Sep 12, 2024

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Sep 12, 2024

cmsbuild merged commit c312b85 into cms-sw:master Sep 12, 2024
11 checks passed

mandrenguyen mentioned this pull request Sep 12, 2024

[14_1_X] Add 2024 HI eras to reco processing configuation #45987

Merged

cmsbuild mentioned this pull request Sep 12, 2024

Fix small typo in makePileupJSON.py: runNumber → run #45989

Merged

mmusich reviewed Oct 2, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 2024 HI eras to reco processing configuation #45981

Add 2024 HI eras to reco processing configuation #45981

mandrenguyen commented Sep 11, 2024

cmsbuild commented Sep 11, 2024 •

edited

Loading

cmsbuild commented Sep 11, 2024

cmsbuild commented Sep 11, 2024

mandrenguyen commented Sep 11, 2024

cmsbuild commented Sep 11, 2024

cmsbuild commented Sep 11, 2024

cmsbuild commented Sep 11, 2024

cmsbuild commented Sep 12, 2024

cmsbuild commented Sep 12, 2024

cmsbuild commented Sep 12, 2024

mandrenguyen commented Sep 12, 2024

cmsbuild commented Sep 12, 2024

mandrenguyen commented Sep 12, 2024

cmsbuild commented Sep 12, 2024

mmusich Oct 2, 2024

mandrenguyen Oct 2, 2024

mandrenguyen Oct 2, 2024

Add 2024 HI eras to reco processing configuation #45981

Add 2024 HI eras to reco processing configuation #45981

Conversation

mandrenguyen commented Sep 11, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Sep 11, 2024 • edited Loading

cmsbuild commented Sep 11, 2024

cmsbuild commented Sep 11, 2024

mandrenguyen commented Sep 11, 2024

cmsbuild commented Sep 11, 2024

Comparison Summary

cmsbuild commented Sep 11, 2024

cmsbuild commented Sep 11, 2024

cmsbuild commented Sep 12, 2024

RelVals-INPUT

Comparison Summary

cmsbuild commented Sep 12, 2024

cmsbuild commented Sep 12, 2024

mandrenguyen commented Sep 12, 2024

cmsbuild commented Sep 12, 2024

Comparison Summary

mandrenguyen commented Sep 12, 2024

cmsbuild commented Sep 12, 2024

mmusich Oct 2, 2024

Choose a reason for hiding this comment

mandrenguyen Oct 2, 2024

Choose a reason for hiding this comment

mandrenguyen Oct 2, 2024

Choose a reason for hiding this comment

cmsbuild commented Sep 11, 2024 •

edited

Loading