-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSim premixing workflows and matrix cleanup #46007
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46007/41808 |
A new Pull Request was created by @kpedro88 for master. It involves the following packages:
@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
please test |
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
5a61648
to
4b89609
Compare
rebased (again) |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46007/42069
|
Pull request #46007 was updated. @AdrianoDee, @Moanwar, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
+1 Size: This PR adds an extra 36KB to repository Comparison SummarySummary:
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 please sign |
+pdmv |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
a. Some special workflow modifications get applied without actually changing any steps, leading to a pointless clone of the main workflow. These can just be filtered out globally.
b. A few special workflows were being applied to all fragments unnecessarily. I have restricted these to just ttbar.
PR validation:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This will be backported to 14_0_X for profiling in the production release.
attn: @sbein @srimanob