Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L1] Protect from "Called C++ object pointer is null" warnings #46058

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

Analysis reports: 1, 2, 3

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46058/41846

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@iarspider iarspider force-pushed the iarspider-patch-20240919-1 branch from 60a058f to fac0ec3 Compare September 19, 2024 14:55
@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • L1Trigger/DTTriggerServerPhi (l1)
  • L1Trigger/GlobalMuonTrigger (l1)
  • L1Trigger/TrackFindingTracklet (l1)

@aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass, @erikbutz, @missirol, @mmusich, @skinnari this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9486b9/41630/summary.html
COMMIT: fac0ec3
CMSSW: CMSSW_14_2_X_2024-09-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46058/41630/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 31a6a74 into cms-sw:master Sep 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants