Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduced a python script for Phase-2 HLT integration tests #46110

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 24, 2024

PR description:

As there has been a recent surge of activities concerning the phase-2 HLT menu, it's important to start engineering some tests to ensure that the basic functionalities of the menu are preserved when configuration updates are introduced.
The goal of this PR is to propose a initial version of a driver script for Phase-2 HLT integration tests to be discussed with the phase2 HLT upgrade community.
The hltIntegrationTests scripts we do have for the Run-3 menu are not well suited for this use case, due to the structure of the phase-2 menu and the necessity to run the L1P2GT step upfront.
This script:

  • creates the configuration for the phase-2 menu from cmssw;
  • for each of the N paths in the menu it creates a copy of the menu with only that one path in the schedule;
  • it runs ten (configurable) GEN-SIM-DIGI-RAW TTbar event for the current phase-2 default geometry (as the time of this PR that would be D110);
  • runs on those events first the full menu and then N jobs for the N single-path versions;
  • finally it loops over the output N root files and compares for each one of the standalone path outputs the trigger results with the full menu.

In case any of the cmsRun process fails, the script fails. In case one of the trigger results comparison fail, the script fails.
Run single-threaded takes about 40 minutes on lxplus. I provide options to run multi-threaded, but it might be too demanding in terms of requested resources if there are parallel cmsRun executions (4 by default).
I think this kind of test should be able to spot early on the kind of issue that were corrected at #46019 or #46054.
As the execution time is quite long, I would propose to run this test in IBs as we do for the Run-3 menus here

PR validation:

In a recent CMSSW_14_2_X IB:

cd HLTrigger/Configuration/python/HLT_75e33/test/
python3 hltPhase2UpgradeIntegrationTests.py

runs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not meant to be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 24, 2024

@cmsbuild, please test

  • even though there's nothing to test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52d644/41728/summary.html
COMMIT: 5f13b1c
CMSSW: CMSSW_14_2_X_2024-09-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46110/41728/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46110 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 25, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52d644/41743/summary.html
COMMIT: ac50279
CMSSW: CMSSW_14_2_X_2024-09-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46110/41743/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich mmusich marked this pull request as ready for review September 25, 2024 16:47
@mmusich
Copy link
Contributor Author

mmusich commented Sep 26, 2024

+hlt

  • we'll follow-up with changes to cms-bot once this is integrated

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c2eaeb6 into cms-sw:master Sep 26, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_phase2IntegrationTests branch September 26, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants