-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduced a python script for Phase-2 HLT integration tests #46110
introduced a python script for Phase-2 HLT integration tests #46110
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46110/41899 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
…tests on a subset of HLT paths only
5f13b1c
to
ac50279
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46110/41912 |
Pull request #46110 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+hlt
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As there has been a recent surge of activities concerning the phase-2 HLT menu, it's important to start engineering some tests to ensure that the basic functionalities of the menu are preserved when configuration updates are introduced.
The goal of this PR is to propose a initial version of a driver script for Phase-2 HLT integration tests to be discussed with the phase2 HLT upgrade community.
The
hltIntegrationTests
scripts we do have for the Run-3 menu are not well suited for this use case, due to the structure of the phase-2 menu and the necessity to run theL1P2GT
step upfront.This script:
cmssw
;GEN-SIM-DIGI-RAW
TTbar event for the current phase-2 default geometry (as the time of this PR that would beD110
);In case any of the
cmsRun
process fails, the script fails. In case one of the trigger results comparison fail, the script fails.Run single-threaded takes about 40 minutes on lxplus. I provide options to run multi-threaded, but it might be too demanding in terms of requested resources if there are parallel
cmsRun
executions (4 by default).I think this kind of test should be able to spot early on the kind of issue that were corrected at #46019 or #46054.
As the execution time is quite long, I would propose to run this test in IBs as we do for the Run-3 menus here
PR validation:
In a recent CMSSW_14_2_X IB:
runs.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, not meant to be backported.