Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for cms-sw/cmssw#45084 #46111

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 24, 2024

resolves #45084

PR description:

This PR is meant as a fix for #45084, originally from @jlidrych.

PR validation:

Tested with the recipe at #45084 (comment).

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 24, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46111/41900

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CalibTracker/SiStripHitEfficiency (alca)
  • CalibTracker/SiStripHitResolution (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@echabert, @gbenelli, @mmusich, @robervalwalsh, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 24, 2024

@cmsbuild please test with cms-sw/cms-bot#2228

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d22c8e/41724/summary.html
COMMIT: c936bf4
CMSSW: CMSSW_14_2_X_2024-09-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46111/41724/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

  • Tests with MALLOC_CONF=junk:true succed

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2228

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 38a391b into cms-sw:master Sep 25, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_fix_for45084 branch September 25, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testSiStripHitResolution and testSiStripHitEfficiency fail when export MALLOC_CONF=junk:true is set
4 participants