Remove run3_nanoAOD_122 & 124 modifiers #46151

hqucms · 2024-09-30T09:47:30Z

PR description:

This PR removes the outdated run3_nanoAOD_122 and run3_nanoAOD_124 era modifiers.

PR validation:

runTheMatrix.py -w nano --ibeos -l 2500.101,2500.111,2500.201,2500.211,2500.024

cmsbuild · 2024-09-30T09:47:56Z

cms-bot internal usage

cmsbuild · 2024-09-30T09:51:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46151/41943

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Era for UPC re-reco of 2016 pPb data #46087, Boosted DeepTauID v2.0 #46112
- File PhysicsTools/NanoAOD/python/boostedTaus_cff.py modified in PR(s): Boosted DeepTauID v2.0 #46112
- File PhysicsTools/NanoAOD/python/jetsAK8_cff.py modified in PR(s): [Superseded by #46523] Add GloParT inference facility #45830
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Adding PAIReDJet Table to NanoAOD #45207, Boosted DeepTauID v2.0 #46112
- File PhysicsTools/NanoAOD/python/nano_eras_cff.py modified in PR(s): Boosted DeepTauID v2.0 #46112

cmsbuild · 2024-09-30T09:52:05Z

A new Pull Request was created by @hqucms for master.

It involves the following packages:

Configuration/Eras (operations)
Configuration/StandardSequences (operations)
PhysicsTools/NanoAOD (xpog)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@AnnikaStein, @GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @mtosi, @rovere, @sameasy, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

hqucms · 2024-09-30T10:06:12Z

enable nano

hqucms · 2024-09-30T10:12:08Z

please test

cmsbuild · 2024-09-30T13:47:24Z

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20eecb/41812/summary.html
COMMIT: 8b32867
CMSSW: CMSSW_14_2_X_2024-09-29-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46151/41812/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
Reco comparison results: 122 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331342
DQMHistoTests: Total failures: 4373
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3326949
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 820 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 55056
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 55056
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
Checked 102 log files, 58 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.941	2.941	0.000 ( +0.0% )	3.09	3.08	+0.4%	6.132	6.059
2500.002	3.050	3.050	0.000 ( +0.0% )	2.74	2.75	-0.1%	6.457	6.405
2500.003	2.995	2.995	0.000 ( +0.0% )	2.87	2.87	-0.1%	6.376	6.399
2500.011	1.534	1.534	0.000 ( +0.0% )	4.69	4.80	-2.2%	2.416	2.419
2500.012	2.032	2.032	0.000 ( +0.0% )	2.87	2.90	-0.9%	2.602	2.600
2500.013	1.873	1.873	0.000 ( +0.0% )	4.05	4.10	-1.2%	2.510	2.518
2500.021	0.022	0.022	0.000 ( +0.0% )	0.95	0.95	+0.5%	2.346	2.353
2500.022	0.022	0.022	0.000 ( +0.0% )	0.92	0.91	+0.6%	2.336	2.343
2500.023	0.022	0.022	0.000 ( +0.0% )	0.91	0.92	-1.2%	2.216	2.212
2500.024	0.022	0.022	0.000 ( +0.0% )	0.68	0.69	-0.8%	2.443	2.453
2500.031	0.035	0.035	0.000 ( +0.0% )	0.85	0.86	-1.2%	2.414	2.413
2500.032	0.036	0.036	0.000 ( +0.0% )	0.87	0.88	-1.7%	2.374	2.378
2500.033	0.037	0.037	0.000 ( +0.0% )	0.77	0.77	+0.1%	2.450	2.455
2500.034	0.036	0.036	0.000 ( +0.0% )	0.78	0.77	+2.4%	2.435	2.441
2500.101	2.732	2.732	0.000 ( +0.0% )	8.58	8.58	-0.0%	6.326	6.338
2500.111	1.389	1.389	0.000 ( +0.0% )	19.44	19.58	-0.7%	2.229	2.232
2500.112	1.806	1.806	0.000 ( +0.0% )	14.91	15.21	-1.9%	2.311	2.315
2500.131	0.747	0.747	0.000 ( +0.0% )	17.44	17.69	-1.4%	1.497	1.491
2500.201	2.557	2.557	0.000 ( +0.0% )	7.42	7.40	+0.2%	5.612	5.609
2500.211	1.700	1.700	0.000 ( +0.0% )	17.26	17.36	-0.6%	2.274	2.275
2500.212	2.096	2.096	0.000 ( +0.0% )	13.65	13.92	-1.9%	2.366	2.361
2500.221	2.004	2.004	0.000 ( +0.0% )	7.55	7.67	-1.5%	2.456	2.454
2500.222	3.281	3.281	0.000 ( +0.0% )	7.32	7.45	-1.8%	2.540	2.540
2500.223	8.968	8.968	0.000 ( +0.0% )	2.59	2.61	-0.7%	2.564	2.539
2500.224	5.787	5.787	0.000 ( +0.0% )	0.60	0.60	-0.7%	2.180	2.152
2500.225	5.805	5.805	0.000 ( +0.0% )	0.57	0.58	-1.5%	2.185	2.167
2500.226	3.044	3.044	0.000 ( +0.0% )	7.30	7.35	-0.7%	2.541	2.540
2500.227	1.437	1.437	0.000 ( +0.0% )	11.28	11.39	-0.9%	1.431	1.430
2500.231	1.404	1.404	0.000 ( +0.0% )	13.49	13.58	-0.6%	2.183	2.187
2500.232	2.301	2.301	0.000 ( +0.0% )	13.45	13.55	-0.8%	2.000	2.037
2500.233	4.748	4.748	0.000 ( +0.0% )	4.16	4.19	-0.7%	2.024	2.001
2500.234	3.501	3.501	0.000 ( +0.0% )	0.76	0.76	-0.5%	1.740	2.066
2500.235	3.513	3.513	0.000 ( +0.0% )	0.74	0.74	-1.0%	2.090	2.075
2500.236	2.145	2.145	0.000 ( +0.0% )	13.45	13.56	-0.8%	2.271	2.268
2500.237	1.016	1.016	0.000 ( +0.0% )	16.59	16.71	-0.7%	1.408	1.456
2500.241	9.404	9.404	0.000 ( +0.0% )	3.45	3.57	-3.4%	1.610	1.948
2500.242	10.331	10.331	0.000 ( +0.0% )	0.83	0.86	-2.9%	1.581	1.732
2500.243	2.712	2.712	0.000 ( +0.0% )	7.72	7.56	+2.1%	1.075	1.073
2500.244	485.976	485.976	0.000 ( +0.0% )	0.54	0.53	+0.6%	1.683	1.671
2500.245	823.202	823.202	0.000 ( +0.0% )	0.70	0.72	-1.7%	1.658	1.663
2500.901	1.777	1.777	0.000 ( +0.0% )	20.29	20.04	+1.2%	1.838	1.843
2500.902	1.626	1.626	0.000 ( +0.0% )	20.82	20.57	+1.2%	1.768	1.768
2500.911	13.995	13.995	0.000 ( +0.0% )	3.92	3.52	+11.3%	1.097	1.096
2500.912	0.437	0.310	0.126 ( +40.7% )	1.87	1.20	+55.0%	0.974	0.975
2500.913	0.110	0.110	0.000 ( +0.0% )	1.15	1.15	+0.1%	0.980	0.967

hqucms · 2024-09-30T20:57:37Z

+1

antoniovilela · 2024-10-03T14:09:34Z

@hqucms
This needs to resolve conflicts.

cmsbuild · 2024-10-03T16:09:25Z

Pull request #46151 was updated. @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @mandrenguyen, @rappoccio can you please check and sign again.

hqucms · 2024-10-03T16:12:03Z

please test

cmsbuild · 2024-10-03T16:12:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46151/42058

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532, Era for UPC re-reco of 2016 pPb data #46087, Boosted DeepTauID v2.0 #46112
- File PhysicsTools/NanoAOD/python/boostedTaus_cff.py modified in PR(s): Boosted DeepTauID v2.0 #46112
- File PhysicsTools/NanoAOD/python/jetsAK8_cff.py modified in PR(s): [Superseded by #46523] Add GloParT inference facility #45830
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Adding PAIReDJet Table to NanoAOD #45207, Boosted DeepTauID v2.0 #46112, Move "hybrid" tau production from nano to mini step #46196
- File PhysicsTools/NanoAOD/python/nano_eras_cff.py modified in PR(s): Boosted DeepTauID v2.0 #46112

cmsbuild · 2024-10-03T16:13:11Z

Pull request #46151 was updated. @antoniovilela, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @mandrenguyen, @rappoccio can you please check and sign again.

cmsbuild · 2024-10-03T19:46:12Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20eecb/41924/summary.html
COMMIT: 31cc8fe
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46151/41924/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 130 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331336
DQMHistoTests: Total failures: 4679
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3326637
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 120 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 55028
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 55028
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
Checked 102 log files, 58 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.941	2.941	0.000 ( +0.0% )	3.10	3.04	+2.0%	6.089	6.056
2500.002	3.050	3.050	0.000 ( +0.0% )	2.75	2.71	+1.5%	6.434	6.428
2500.003	2.994	2.994	0.000 ( +0.0% )	2.91	2.82	+3.1%	6.409	6.383
2500.011	1.534	1.534	0.000 ( +0.0% )	4.82	4.61	+4.6%	2.139	2.139
2500.012	2.031	2.031	0.000 ( +0.0% )	2.90	2.82	+2.9%	2.184	2.179
2500.013	1.873	1.873	0.000 ( +0.0% )	4.18	4.01	+4.2%	2.210	2.200
2500.021	0.022	0.022	0.000 ( +0.0% )	0.98	0.89	+10.1%	2.364	2.050
2500.022	0.022	0.022	0.000 ( +0.0% )	0.90	0.88	+1.9%	2.352	2.029
2500.023	0.022	0.022	0.000 ( +0.0% )	0.93	0.85	+9.5%	2.245	1.871
2500.024	0.022	0.022	0.000 ( +0.0% )	0.71	0.65	+9.0%	2.378	2.178
2500.031	0.035	0.035	0.000 ( +0.0% )	0.86	0.79	+8.6%	2.407	2.051
2500.032	0.036	0.036	0.000 ( +0.0% )	0.89	0.81	+9.9%	2.404	2.027
2500.033	0.037	0.037	0.000 ( +0.0% )	0.78	0.69	+14.0%	2.431	2.086
2500.034	0.036	0.036	0.000 ( +0.0% )	0.80	0.74	+7.7%	2.415	2.099
2500.101	2.732	2.732	0.000 ( +0.0% )	9.03	8.36	+8.1%	6.353	6.356
2500.111	1.389	1.389	0.000 ( +0.0% )	19.93	18.48	+7.9%	2.231	2.210
2500.112	1.806	1.806	0.000 ( +0.0% )	15.66	14.24	+10.0%	2.310	2.313
2500.131	0.747	0.747	0.000 ( +0.0% )	18.30	17.24	+6.2%	1.494	1.494
2500.201	2.557	2.557	0.000 ( +0.0% )	7.87	7.10	+10.8%	6.236	5.608
2500.211	1.700	1.700	0.000 ( +0.0% )	18.15	16.81	+8.0%	2.281	2.273
2500.212	2.096	2.096	0.000 ( +0.0% )	14.45	13.26	+8.9%	2.358	2.359
2500.221	2.004	2.004	0.000 ( +0.0% )	7.97	7.49	+6.5%	2.449	2.447
2500.222	3.281	3.281	0.000 ( +0.0% )	7.75	7.28	+6.5%	2.534	2.543
2500.223	8.968	8.968	0.000 ( +0.0% )	2.68	2.53	+6.0%	2.561	2.558
2500.224	5.787	5.787	0.000 ( +0.0% )	0.60	0.59	+2.4%	2.594	2.265
2500.225	5.805	5.805	0.000 ( +0.0% )	0.59	0.57	+3.5%	2.613	2.266
2500.226	3.044	3.044	0.000 ( +0.0% )	7.67	7.25	+5.9%	2.536	2.539
2500.227	1.437	1.437	0.000 ( +0.0% )	11.96	11.08	+7.9%	1.432	1.428
2500.231	1.404	1.404	0.000 ( +0.0% )	14.48	13.25	+9.3%	2.186	2.181
2500.232	2.301	2.301	0.000 ( +0.0% )	14.26	13.17	+8.3%	2.265	2.266
2500.233	4.748	4.748	0.000 ( +0.0% )	4.34	4.08	+6.3%	2.293	2.281
2500.234	3.501	3.501	0.000 ( +0.0% )	0.77	0.75	+3.5%	2.300	2.060
2500.235	3.513	3.513	0.000 ( +0.0% )	0.75	0.73	+2.3%	2.328	2.084
2500.236	2.145	2.145	0.000 ( +0.0% )	14.35	13.44	+6.8%	2.268	2.262
2500.237	1.016	1.016	0.000 ( +0.0% )	17.28	15.56	+11.1%	1.461	1.445
2500.241	9.404	9.404	0.000 ( +0.0% )	3.71	3.29	+12.7%	1.945	1.947
2500.242	10.331	10.331	0.000 ( +0.0% )	0.91	0.83	+9.7%	1.735	1.732
2500.243	2.712	2.712	0.000 ( +0.0% )	8.29	7.41	+11.9%	1.076	1.075
2500.244	485.976	485.976	0.000 ( +0.0% )	0.58	0.52	+10.6%	1.679	1.676
2500.245	823.202	823.202	0.000 ( +0.0% )	0.76	0.70	+9.2%	1.660	1.645
2500.901	1.777	1.777	0.000 ( +0.0% )	21.65	20.35	+6.4%	1.843	1.838
2500.902	1.626	1.626	0.000 ( +0.0% )	21.61	19.45	+11.1%	1.774	1.769
2500.911	13.995	13.995	0.000 ( +0.0% )	2.65	2.92	-9.2%	1.098	1.093
2500.912	0.240	0.132	0.108 ( +82.0% )	1.15	1.18	-2.4%	0.974	0.977
2500.913	0.110	0.110	0.000 ( +0.0% )	1.17	1.12	+4.8%	0.977	0.977

hqucms · 2024-10-03T20:39:14Z

+1

antoniovilela · 2024-10-08T13:49:27Z

+1

cmsbuild · 2024-10-08T13:49:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_14_2_X milestone Sep 30, 2024

cmsbuild added operations-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Sep 30, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 30, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2024

cmsbuild added tests-approved and removed tests-started labels Sep 30, 2024

This was referenced Sep 30, 2024

Boosted DeepTauID v2.0 #46112

Merged

Era for UPC re-reco of 2016 pPb data #46087

Merged

cmsbuild added xpog-approved and removed xpog-pending labels Sep 30, 2024

This was referenced Oct 2, 2024

[MiniAOD, NanoAOD] Update AK8 subjet b-taggers, add pileup jet ID #46191

Merged

Move "hybrid" tau production from nano to mini step #46196

Merged

hqucms force-pushed the xpog/nano-drop-era-12X branch from 8b32867 to 86faa5d Compare October 3, 2024 16:07

cmsbuild removed tests-approved code-checks-approved labels Oct 3, 2024

Remove run3_nanoAOD_122 & 124 modifiers.

31cc8fe

hqucms force-pushed the xpog/nano-drop-era-12X branch from 86faa5d to 31cc8fe Compare October 3, 2024 16:11

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 3, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2024

cmsbuild added xpog-approved and removed xpog-pending labels Oct 3, 2024

This was referenced Oct 7, 2024

[BTVNano] add NegTag for UParT #46288

Merged

[NanoAOD] Add UParT electron and muon raw scores #46299

Merged

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Oct 8, 2024

cmsbuild merged commit d8f3e55 into cms-sw:master Oct 8, 2024
13 checks passed

cmsbuild mentioned this pull request Oct 9, 2024

Fix testAOTTools for non-amd64 arch #46315

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove run3_nanoAOD_122 & 124 modifiers #46151

Remove run3_nanoAOD_122 & 124 modifiers #46151

hqucms commented Sep 30, 2024

cmsbuild commented Sep 30, 2024 •

edited

Loading

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

hqucms commented Sep 30, 2024

hqucms commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

hqucms commented Sep 30, 2024

antoniovilela commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

hqucms commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

hqucms commented Oct 3, 2024

antoniovilela commented Oct 8, 2024

cmsbuild commented Oct 8, 2024

Remove run3_nanoAOD_122 & 124 modifiers #46151

Remove run3_nanoAOD_122 & 124 modifiers #46151

Conversation

hqucms commented Sep 30, 2024

PR description:

PR validation:

cmsbuild commented Sep 30, 2024 • edited Loading

cmsbuild commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

hqucms commented Sep 30, 2024

hqucms commented Sep 30, 2024

cmsbuild commented Sep 30, 2024

Comparison Summary

NANO Comparison Summary

hqucms commented Sep 30, 2024

antoniovilela commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

hqucms commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

Comparison Summary

NANO Comparison Summary

hqucms commented Oct 3, 2024

antoniovilela commented Oct 8, 2024

cmsbuild commented Oct 8, 2024

cmsbuild commented Sep 30, 2024 •

edited

Loading