Tracking validation updates/improvements

[mmasciov]

PR description:

This PR is aimed at updating/improving Multi-Track Validation in terms of style/readability and content.
In particular:

• Line colors are set to the same colors as markers (instead of black), and labels are increased for timing plots.
• Resolution plots are added per iteration, only for tracks byOriginalAlgo, to allow for more detailed studies.
• For phase-2, default pseudorapidity range for efficiency plot is increased to |η|<3.5.
• Cut on transverse impact parameter (TIP) is set to the same value for all efficiency plots (but efficiency vs TIP); previously, TIP cut was only updated for efficiency vs η.

FYI, @kskovpen

[cmsbuild]

cms-bot internal usage

[mmasciov]

type tracking

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46324/42157

[cmsbuild]

A new Pull Request was created by @mmasciov for master.

It involves the following packages:

• Validation/RecoTrack (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @missirol, @mmusich, @mtosi, @rovere, @wmtford this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmasciov]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46324/42158

[cmsbuild]

Pull request #46324 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

[mmasciov]

@cmsbuild please test

[AdrianoDee]

@AdrianoDee, I have modified this PR to only add the resolution plots for trackingOnly workflows. FYI, @mandrenguyen

Very much appreciated @mmasciov.

[mmasciov]

Of course, @cms-sw/dqm-l2 shall also resign eventually. Thanks in advance!

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c52330/42196/summary.html
COMMIT: 04e97eb
CMSSW: CMSSW_14_2_X_2024-10-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46324/42196/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2024.1000012024.100001_RunJetMET02024C_10k/step1_dasquery.log
• 2024.100001DAS Error

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 124 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3441757
• DQMHistoTests: Total failures: 89627
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3352110
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 168 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[mmasciov]

@mandrenguyen, @cms-sw/dqm-l2 (FYI: @AdrianoDee): the error seems to be fully unrelated with this PR, and the comment about the increase in memory was addressed. Can this PR be signed again by DQM, unhold (by Matthew) and eventually merged?
Thanks!

[mmasciov]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c52330/42241/summary.html
COMMIT: 04e97eb
CMSSW: CMSSW_14_2_X_2024-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46324/42241/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3441825
• DQMHistoTests: Total failures: 84884
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356921
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 168 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[mmasciov]

@mandrenguyen, this should be ready to be unhold and merged. Thanks

[mmasciov]

Gentle ping to @cms-sw/dqm-l2 and @cms-sw/orp-l2

[antoniovagnerini]

+1

[antoniovilela]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1