MTD validation: update vertex density plots

[fabiocos]

PR description:

In the Primary4DVertexValidation class, a set of plots is devoted to show the true and reconstructed vertex density as a function of space (line density along the beam line in the z coordinate) and time. Previously a parameterization of the simulated HL-LHC beam spot profile in z was used to weight entries, now just simple distributions, scaled by the total number of events to provide the per event density, are filled. The bin numbers have been significantly reduced, to improve the memory footprint of this code.

PR validation:

Code compiles, runs and provide the desired plots, showing that the expected beam spot sigma is about 4.29 cm and the corresponding time spread sigma is about 194 ps (on /store/relval/CMSSW_14_2_0_pre2/RelValTTbar_14TeV/GEN-SIM-RECO/PU_141X_mcRun4_realistic_v1_STD_2026D110_PU-v1/2580000/bc39e0cf-b5f9-40ce-9dac-af84dc3e049a.root).

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46476/42332

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46476/42332/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46476/42332/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46476/42333

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90b1a5/42339/summary.html
COMMIT: 4c0ef05
CMSSW: CMSSW_14_2_X_2024-10-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46476/42339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3566325
• DQMHistoTests: Total failures: 427
• DQMHistoTests: Total nulls: 12
• DQMHistoTests: Total successes: 3565866
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -21.461999999999996 KiB( 45 files compared)
• DQMHistoSizes: changed ( 24834.911,... ): -3.577 KiB MTD/Vertices
• Checked 201 log files, 171 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[antoniovagnerini]

+1

• spurious errors from HGCal DQM test (open issue Non reproducibility in HGCal DQM #46416 )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1