Improve ScoutingNano integration with autoNano #46516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46516/42368 |
|
A new Pull Request was created by @patinkaew for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable nano |
|
please test |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
Hi @hqucms, Thank you for the tests! It's great to see that the size increase is quite small. I forgot to mention clearly, but there are also hfEmEF and hfHEF energy fractions introduced for reclustered jets. This can explain slightly increase in size. I mentioned this PR in the mattermost and will present this briefly during HLT Scouting meeting this Thursday. I opened draft PR here so people can get to see the changes clearer for better code review. Once we finalise the discussion, I will change to actual PR and we can merge. |
|
Hi @hqucms, We had a meeting yesterday and @elfontan suggested that we should also have a relval_nano workflow to test |
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46516/42614 |
|
Pull request #46516 was updated. @cmsbuild, @ftorrresd, @hqucms can you please check and sign again. |
|
please test |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
+1 |
|
Dear @AdrianoDee, @DickyChant, @miquork, @srimanob, @subirsarkar, @Moanwar, Sorry for pinging you. Can pdmv and upgrade please check and approve if there are no more comments? Best, |
|
+Upgrade |
|
please test |
|
+pdmv |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pending-signatures
pdmv-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 Size: This PR adds an extra 12KB to repository
Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR improves ScoutingNano integration with autoNano. This mainly concerns using ScoutingNano flavour in combination with other nano flavours. The primary use case is in scouting vs offline object comparison studies using ScoutingPFMonitor datasets. Currently, ScoutingNano configuration replaces
nanoSequencewhich is also used in standard nano, making combining ScoutingNano with standard NanoAOD unclear and difficult. While there exist recipes to compose scouting+standard, they are not intuitive and do not use the autoNano functionalities. Hence, this PR implements changes to allow combining scouting+standard with autoNano. This is achieved by creating newscoutingNanoSequencein the configuration file and not altering standardnanoSequence. For combining scouting+standard, bothscoutingNanoSequenceandnanoSequencewill be scheduled on different paths to run. Additionally, in principle, ScoutingNano will be able to combine with other nano flavours in autoNano as well.The changes also aims to better integrate with T0 processing workflow to prepare for scouting+standard NanoAOD production for ScoutingPFMonitor dataset in the future.
In addition, we use this opportunity to also
cmsDriver.py --customise:An accompanying documentation for this change is also available [1]. Examples using autoNano are provided and checked.
PR validation:
Pass all tests from
scram b runtests use-ibeosPass all tests from
runTheMatrix.py -l limited -i all --ibeosIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport and there is currently no plan for a backport.
[1] https://codimd.web.cern.ch/s/_sVpKamo5