ETL Digitization: update of pulse shape

[24LopezR]

PR description:

This PR modifies the base pulse shape used in the ETL digitization model, as well as the time walk correction parameters and the measure of the ETL time resuloution (used for obtaining the ETL RecHits). For more details check the relevant presentations:

MTD DPG (04/10/24): https://indico.cern.ch/event/1458405/#12-etl-pulse-shape-update-in-s
MTD DPG (25/10/24): https://indico.cern.ch/event/1466678/#15-update-of-etl-digitization

PR validation:

Standard validation run with TTBar 14 TeV workflow (31234.0), expected changes in LocalReco plots

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, and it is not intended for backporting.

@fabiocos @martinamalberti

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46529/42390

[cmsbuild]

A new Pull Request was created by @24LopezR for master.

It involves the following packages:

• RecoLocalFastTime/FTLRecProducers (upgrade, reconstruction)
• SimFastTiming/FastTimingCommon (upgrade, simulation)
• Validation/MtdValidation (dqm)

@Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @nothingface0, @rvenditti, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcf93f/42425/summary.html
COMMIT: c7fccd1
CMSSW: CMSSW_14_2_X_2024-10-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46529/42425/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 1936 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3569177
• DQMHistoTests: Total failures: 232
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3568925
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 201 log files, 171 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[civanch]

+simulation

[antoniovagnerini]

+dqm

• spurious differences from HGCal DQM test (open issue Non reproducibility in HGCal DQM #46416)

[jfernan2]

+1

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1