Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Fix ZMu skimming code for 2024 PbPb data taking #46585

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

flodamas
Copy link
Contributor

@flodamas flodamas commented Nov 2, 2024

PR description:

Backport of #46584

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

A new Pull Request was created by @flodamas for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@AdrianoDee, @cmsbuild, @DickyChant, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

cms-bot internal usage

@AdrianoDee
Copy link
Contributor

please test workflow 142.0

@mandrenguyen
Copy link
Contributor

backport of #46584

@AdrianoDee
Copy link
Contributor

urgent
(see #46458 (review))

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2024

type bug-fix

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcf261/42552/summary.html
COMMIT: 3cfdab7
CMSSW: CMSSW_14_1_X_2024-11-01-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46585/42552/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3628433
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3628406
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 140.56 ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 140.56 ): 0.004 KiB MessageLogger/Warnings
  • Checked 203 log files, 172 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit d108f18 into cms-sw:CMSSW_14_1_X Nov 2, 2024
9 checks passed
@flodamas flodamas deleted the FixPbPbZMuSkim_141X branch November 2, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants