Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the L1T seeds to be monitored from L1TStage2uGTTiming in Run3 PbPb modes #46590

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 2, 2024

PR description:

Addresses #43488 (comment), by removing from DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py the monitoring seeds not existing in the Run3 PbPb L1T menus.

PR validation:

Run the setup at #46584 (comment) with this commit and verified that the noisy warnings are removed.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, to be backported to CMSSW_14_1_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

test parameters:

  • workflows = 160, 160.02, 160.03, 160.1, 160.2, 160.3, 160.4, 160.501, 161, 161.02, 161.03, 161.1, 161.2, 161.3, 161.4, 180.0, 180.1, 181, 181.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

@cmsbuild, please test

@mmusich mmusich changed the title adjust the L1T seed to be monitored from L1TStage2uGTTiming in Run3 PbPb modes adjust the L1T seeds to be monitored from L1TStage2uGTTiming in Run3 PbPb modes Nov 2, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

Pull request #46590 was updated. @antoniovagnerini, @rseidita can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-836ebf/42559/summary.html
COMMIT: 5835ec4
CMSSW: CMSSW_14_2_X_2024-11-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46590/42559/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Nov 3, 2024

You potentially removed 169 lines from the logs

as expected this silences quite a few warnings.

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 12ead85 into cms-sw:master Nov 5, 2024
12 checks passed
@mmusich mmusich deleted the mm_dev_silence_L1TStage2uGTTiming_cfi_onPbPb branch November 5, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants