[Simulation] Allow DT ageing toy model to run at the DIGI-L1T step

[battibass]

PR description:

This pull request updates the toy model used to account for potential DT cell inefficiencies due to aging, so that it can be applied at the digitization step. This allows for a consistent impact on simulated digis before packing and trigger-primitive generation.

PR validation:

To be applied, DT aging a customization function should be used, no effect is expected in standard workflows.

Local testing was performed by adding the customization function in the step2 of runTheMatrix.py -w upgrade 12809.0 and analyzing the produced samples.Results will be presented at the Simulation meeting

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46732/42702

[cmsbuild]

A new Pull Request was created by @battibass for master.

It involves the following packages:

• SimMuon/DTDigitizer (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@jhgoh, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6018d/42946/summary.html
COMMIT: 71fb208
CMSSW: CMSSW_14_2_X_2024-11-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46732/42946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3344340
• DQMHistoTests: Total failures: 429
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343891
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[civanch]

@battibass , please, have a look into https://github.com/cms-sw/cmssw/blob/master/SLHCUpgradeSimulations/Configuration/python/aging.py#L245-L257
It seems to be the optimal place where aging for DT is enabled.

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

[civanch]

+1

to avoid cross-release issues it is better to merge this PR. To complete aging simulation a new PR is needed, see issue #46788

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1