Updated Input tags and code additions for TOP Production DQM GEN-SIM-RECO

[dsidirop1]

Description of PR

• The main changes expected relate to the histograms for the non mini AOD (RECO) directories of TOP DQM Production now being filled (to previously being empty) after the input tags for Muons, Electrons, Jets and the B-tags were updated to non obsolete tags included in the most recent input files for CMSSW_14_2_0_pre3. Fot the updated B-tags from the old CSV ones to deepCSV the working points were updated accordingly based on the 2018 campaign as described on the BTV internal wiki.
• Other changes made include:

1. the update from <reco::PFCandidate> objects which are obsolete to f.e. <reco::Muon>, <reco::GsfElectron> per the relevant objects found in the input files used.
2. The update of selection cuts structure to remove unnecessary references and dependencies e.g. mediumMuonCut = looseMuonCut + " muonRef.innerTrack.validFraction > 0.8" becomes mediumMuonCut = looseMuonCut + " innerTrack.validFraction > 0.8".
3. Some unnecessary checks in loops like:

 if (muonit->muonRef().isNull())
        continue;
      reco::MuonRef muon = muonit->muonRef();

in TopSingleLeptonDQM.cc were removed completely.
4. Histograms for jets 3 and 4 were added to SingleTopTChannelLeptonDQM.cc for completion purposes and to align it with the TopSingleLeptonDQM.cc analysis.
5. Certain comments that were not useful or obsolete were removed to make the code more conscise.

• There is a minor dependence on a previous PR number Updated btags and Working Points for Top Production mini AOD DQM  #44299 which dealt with the same issues for the miniAOD directories in the TOP DQM where the main focus was tag updating as in here.
• BTV internal wiki 2018 campaign

PR validation:

Changes have been made to the following files:

• DQM/Physics/interface/TopDQMHelpers.h
• DQM/Physics/python/singleTopDQM_cfi.py
• DQM/Physics/python/topSingleLeptonDQM_cfi.py
• DQM/Physics/src/SingleTopTChannelLeptonDQM.cc
• DQM/Physics/src/SingleTopTChannelLeptonDQM.h
• DQM/Physics/src/TopDQMHelpers.cc
• DQM/Physics/src/TopSingleLeptonDQM.cc
• DQM/Physics/src/TopSingleLeptonDQM.h
• DQM/Physics/test/topDQM_harvesting_cfg.py
• DQM/Physics/test/topDQM_production_cfg.py

To verify the results of the aforementioned actions the file DQM/Physics/test/topDQM_production_cfg.py was executed with cmsRun to produce a .root file that was then used as input for the DQM/Physics/test/topDQM_harvesting_cfg.py to produce a tree with the relevant histograms needed that were browsed using the TBrowser root feature. As evidence of the success of the task two of those histograms (one from TopSingleMuonMediumDQM and the other from SingleTopElectronMediumDQM) are attached on this PR.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42720

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42720/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42720/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42727

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42727/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42727/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42737

[cmsbuild]

A new Pull Request was created by @dsidirop1 for master.

It involves the following packages:

• DQM/Physics (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

[dsidirop1]

PR has been cleaned up properly please test again

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42782

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42782/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42782/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46749/42783

[cmsbuild]

Pull request #46749 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

[antoniovagnerini]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02dfbd/43098/summary.html
COMMIT: fd13e2c
CMSSW: CMSSW_15_0_X_2024-11-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46749/43098/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3482690
• DQMHistoTests: Total failures: 7347
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3475323
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 276.57699999999977 KiB( 45 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 6.973 KiB Physics/Top
• DQMHistoSizes: changed ( 10224.0,... ): 6.902 KiB Physics/Top
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 1 / 44 workflows

[antoniovagnerini]

+1

• spurious differences from HGCal DQM test (open issue Non reproducibility in HGCal DQM #46416)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1