Phase2-hgx360FX Attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 and #46610

[bsunanda]

PR description:

Attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 and #46610

PR validation:

Use the runTheMatrix test workflows and the new workflow 32434.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46755/42734

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Configuration/Geometry/python/GeometryDD4hepExtendedRun4D116Reco_cff.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Configuration/Geometry/python/GeometryDD4hepExtendedRun4D116_cff.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Configuration/Geometry/python/GeometryExtendedRun4D116Reco_cff.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Configuration/Geometry/python/GeometryExtendedRun4D116_cff.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Configuration/Geometry/python/dictRun4Geometry.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Configuration/PyReleaseValidation/python/relval_Run4.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, ECAL RecHit producer Alpaka migration #46453, Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610, Rename 2021 Wfs with 2022 #46649, Allowing Cluster Splitting with HLT Vertices #46694
  • File Configuration/StandardSequences/python/GeometryConf.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610, Run3-hcx379 First version of 2025 scenario - still needed the correct PPS geometry with the needed rotation #46705
  • File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometryRun4D116.xml modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Geometry/CMSCommonData/python/cmsExtendedGeometryRun4D116XML_cfi.py modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Geometry/ForwardCommonData/data/forwardshield/2026/v5/forwardshield.xml modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Geometry/MuonCommonData/data/ge0/TDR_Dev/v5/ge0.xml modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Geometry/MuonCommonData/data/mb3/2015/v3/mb3.xml modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610
  • File Geometry/MuonCommonData/data/muonYoke/2026/v4/muonYoke.xml modified in PR(s): Phase2-hgx360F First attempt to make a Phase2 scenario with 0 overlaps with zero tolerance in lieu of #46565 #46610

[bsunanda]

@cmsbuild Please test

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• Configuration/StandardSequences (operations)
• Geometry/CMSCommonData (geometry, upgrade)
• Geometry/ForwardCommonData (geometry)
• Geometry/MuonCommonData (geometry)

@AdrianoDee, @Dr15Jones, @Moanwar, @antoniovilela, @bsunanda, @civanch, @davidlange6, @DickyChant, @fabiocos, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @miquork, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @VourMa, @dgulhan, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @mtosi, @ptcox, @rovere, @sameasy, @slomeo, @vargasa, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d45696/42988/summary.html
COMMIT: 5526ab3
CMSSW: CMSSW_14_2_X_2024-11-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46755/42988/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 489
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3483213
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 1 / 44 workflows

[bsunanda]

+geometry

[bsunanda]

@AdrianoDee, @subirsarkar, @Moanwar, Please approve this PR

[subirsarkar]

+Upgrade

[bsunanda]

@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy Please merge this PR

[srimanob]

As far as I see, this PR is not tested properly. When new geometry is added, we should trigger the test on that.

[srimanob]

test parameters:

• workflows = 32434.0
• relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,Run4

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d45696/43020/summary.html
COMMIT: 5526ab3
CMSSW: CMSSW_14_2_X_2024-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46755/43020/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 407
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3483295
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[bsunanda]

@srimonab That test was made before the PR was made. Anyway you triggered the test and there was no issue. Please do not make other statements to delay integration of this PR.

[bsunanda]

@antoniovilela, and @mandrenguyen Please integrate this PR urgently. This prevents me to go to the next step.

[srimanob]

Hi @bsunanda
Do you miss #46755 (comment) ?

Thx.

[srimanob]

@srimonab That test was made before the PR was made. Anyway you triggered the test and there was no issue. Please do not make other statements to delay integration of this PR.

I don't understand why do you always think that comments makes the delay of PR? If thing is done properly, no one want to delay any PRs. The comment on missings, on test, the intention is to keep CMSSW in a good shape.

[bsunanda]

Please merge this PR. I need the merged PR to work on a Phase2 scenario with no overlap

[srimanob]

Could you please at least acknowledge on missing on updating the README. It can come in later PR, I don't request to have it here.

OK, i see you replied already in the above comment. Thx.

[bsunanda]

README.md file was not modified in this PR to avoid conflict on the changes in Run3 modification. I shall include them in the next PR where I also plan to add the changes of the muon section with modified mb4shield for the missing DT shield updates.

[bsunanda]

@antoniovilela, @mandrenguyen, I wonder why this PR is not getting integrated. Can you please tell me the reason

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.