Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANALYSIS] py2/3 compatibility:drop use of __future__ #46768

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

smuzaffar
Copy link
Contributor

see #46762

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • DPGAnalysis/SiStripTools (analysis)
  • MuonAnalysis/MuonAssociators (analysis)
  • PhysicsTools/FWLite (analysis)
  • PhysicsTools/Heppy (analysis)
  • PhysicsTools/HeppyCore (analysis)
  • PhysicsTools/JetMCAlgos (analysis)
  • PhysicsTools/PatExamples (analysis)
  • PhysicsTools/PythonAnalysis (analysis)
  • PhysicsTools/TagAndProbe (analysis)
  • TopQuarkAnalysis/Configuration (analysis)
  • TopQuarkAnalysis/TopEventProducers (analysis)
  • TopQuarkAnalysis/TopObjectResolutions (analysis)
  • TopQuarkAnalysis/TopSkimming (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@AlexDeMoor, @CeliaFernandez, @Fedespring, @HuguesBrun, @Ming-Yan, @ReyerBand, @Senphy, @VinInn, @VourMa, @abbiendi, @andrea21z, @andrzejnovak, @argiro, @battibass, @bellan, @castaned, @cericeci, @echabert, @jandrea, @jhgoh, @missirol, @mmusich, @mtosi, @rchatter, @robervalwalsh, @thomreis, @threus, @trocino, @venturia, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Nov 22, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 472KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9f986/43021/summary.html
COMMIT: 8d027cc
CMSSW: CMSSW_14_2_X_2024-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46768/43021/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMGUIUpload had ERRORS

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3483722
  • DQMHistoTests: Total failures: 496
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3483206
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 1 / 44 workflows

@tvami
Copy link
Contributor

tvami commented Nov 23, 2024

ignore tests-rejected with ib-failure

@tvami
Copy link
Contributor

tvami commented Nov 23, 2024

+1

  • technical

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 968c13b into cms-sw:master Nov 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants