Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leak in RegionalMuonGMTUnpacker [14_0] #46950

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This was discovered while analyzing a re-reco job for memory issues.

PR validation:

Code compiles and was checked in master.

backport #46918

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 15, 2024

A new Pull Request was created by @Dr15Jones for CMSSW_14_0_X.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 15, 2024

cms-bot internal usage

@Dr15Jones Dr15Jones changed the title Fixed memory leak in RegionalMuonGMTUnpacker Fixed memory leak in RegionalMuonGMTUnpacker [14_0] Dec 15, 2024
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09c369/43453/summary.html
COMMIT: 8698da2
CMSSW: CMSSW_14_0_X_2024-12-15-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46950/43453/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

backport of #46918

@mandrenguyen
Copy link
Contributor

@cms-sw/l1-l2 would you kindly have a look, as we would like to build a 14_0_X release today?

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f458e48 into cms-sw:CMSSW_14_0_X Dec 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants