Decrease temporary memory held by PuppiProducer

[Dr15Jones]

PR description:

Avoid holding memory between Events which is then released at the beginning of the next Event.
Also did code modernization/improvements.

This was discovered while using ModuleEventAllocMonitor service on a ReReco job.

PR validation:

Code compiles.

[Dr15Jones]

@makortel FYI

[Dr15Jones]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47015/43119

[cmsbuild]

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

• CommonTools/PileupAlgos (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ahinzmann, @gkasieczka, @hatakeyamak, @jdolen, @missirol, @rappoccio this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bad74d/43578/summary.html
COMMIT: c382271
CMSSW: CMSSW_15_0_X_2024-12-19-1600/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47015/43578/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3818210
• DQMHistoTests: Total failures: 429
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3817761
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1

[makortel]

Comparison differences are related to #39803 and #46416