-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update customiseHybrid
to comply with new definition of siStripClusters
#47054
Conversation
type bug-fix |
cms-bot internal usage |
urgent
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47054/43202 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
please test lets checkout the packages where units are failing so that bot can run those tests |
@cmsbuild please abort |
the unit test for that is fixed in another PR: #47052. It will fail here. |
oops sorry, I have removed the test parameter. Feel free to restart the tests |
test parameters:
|
@cmsbuild, please test |
no worries. thanks for the follow-up. |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #47017 introduced a
fillDescriptions
method forSiStripClusterizer
and refined the objectsiStripClusters
asthis broke several unit tests of the package
Configuration/DataProcessing
, see e.g. this log.This PR fixes the issue by updating
customiseHybrid
to comply with new definition ofsiStripClusters
PR validation:
The following unit tests now run fine:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A