Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update customiseHybrid to comply with new definition of siStripClusters #47054

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 8, 2025

PR description:

PR #47017 introduced a fillDescriptions method for SiStripClusterizer and refined the object siStripClusters as

from RecoLocalTracker.SiStripClusterizer.siStripClusterizer_cfi import siStripClusterizer as _siStripClusterizer
siStripClusters = _siStripClusterizer.clone()

this broke several unit tests of the package Configuration/DataProcessing, see e.g. this log.
This PR fixes the issue by updating customiseHybrid to comply with new definition of siStripClusters

PR validation:

The following unit tests now run fine:

scram b runtests_TestConfigDP_2
scram b runtests_TestConfigDP_3
scram b runtests_TestConfigDP_5

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

urgent

  • fixes IB unit tests

@cmsbuild cmsbuild added the urgent label Jan 8, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • RecoLocalTracker/SiStripZeroSuppression (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @alesaggio, @echabert, @felicepantaleo, @gbenelli, @gpetruc, @jlidrych, @missirol, @mmusich, @mtosi, @robervalwalsh, @rovere, @threus, @yduhm this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

@cmsbuild, please test

@smuzaffar
Copy link
Contributor

please test

lets checkout the packages where units are failing so that bot can run those tests

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

@cmsbuild please abort

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

@smuzaffar

PhysicsTools/PatAlgos

the unit test for that is fixed in another PR: #47052. It will fail here.

@smuzaffar
Copy link
Contributor

smuzaffar commented Jan 8, 2025

oops sorry, I have removed the test parameter. Feel free to restart the tests

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

test parameters:

  • addpkg = Configuration/DataProcessing

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Jan 8, 2025

oops sorry, I have removed the test parameter. Feel free to restart the tests

no worries. thanks for the follow-up.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fc2ab/43663/summary.html
COMMIT: 974bebf
CMSSW: CMSSW_15_0_X_2025-01-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47054/43663/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Jan 8, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e804087 into cms-sw:master Jan 8, 2025
12 checks passed
@mmusich mmusich deleted the mm_fix_customiseHybrid branch January 8, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants