Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BTV,DQM] Add tagger inputs plots for DQM and Validation #47167

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

nurfikri89
Copy link
Contributor

PR description:

As a follow up of PR #46674, this PR expands the BTV DQM & Validation plots by adding DeepJet, ParticleNet and UParT taggers' input variables. For Validation, plots are also categorized according to jet's partonFlavour value.

PR validation:

  • All DQM & Validation plots are accounted for and successfully filled. Tested using wf 2500.024.
  • passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos with the exception of a few workflows which failed because of missing relval input files.
  • passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 22, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

  • DQMOffline/RecoB (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @rociovilar this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d32376/43927/summary.html
COMMIT: 872e32f
CMSSW: CMSSW_15_0_X_2025-01-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47167/43927/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 23-Jan-2025 12:19:25 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step1'
   [2] Calling method for module MiniAODTagInfoAnalyzer/'patJetsPuppiForwardTagInfoAnalyzerValidation'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Jet
Looking for module label: updatedPatJetsSlimmedPuppiWithDeepTags
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

  • 159.01159.01_HydjetQ_reminiaodPbPb2022_INPUT/step2_HydjetQ_reminiaodPbPb2022_INPUT.log
  • 140.5611140.5611_RunHI2018reMINIAOD/step2_RunHI2018reMINIAOD.log

…lude the tagger inputs analyzers for pp_on_AA eras
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #47167 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

@nurfikri89
Copy link
Contributor Author

I have committed the fixes which should resolve the failing relvals. Unfortunately, I am unable to test those workflows on lxplus as they all had failed due to file access issues.

@antoniovagnerini
Copy link

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d32376/43959/summary.html
COMMIT: 48ad4de
CMSSW: CMSSW_15_0_X_2025-01-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47167/43959/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3932183
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3932160
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7332.6720000000005 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 24.940 KiB Btag/TagInfo_pfParticleNetFromMiniAODAK4PuppiCentral_Inc
  • DQMHistoSizes: changed ( 10224.0,... ): 24.940 KiB Btag/TagInfo_pfParticleNetFromMiniAODAK4PuppiForward_Inc
  • DQMHistoSizes: changed ( 10224.0,... ): 24.790 KiB Btag/TagInfo_pfParticleNetFromMiniAODAK4PuppiCentral_B
  • DQMHistoSizes: changed ( 10224.0,... ): 24.790 KiB Btag/TagInfo_pfParticleNetFromMiniAODAK4PuppiCentral_C
  • DQMHistoSizes: changed ( 10224.0,... ): 24.790 KiB Btag/TagInfo_pfParticleNetFromMiniAODAK4PuppiCentral_L
  • DQMHistoSizes: changed ( 10224.0,... ): 23.873 KiB Btag/TagInfo_pfUnifiedParticleTransformerAK4_Inc
  • DQMHistoSizes: changed ( 10224.0,... ): 23.738 KiB Btag/TagInfo_pfUnifiedParticleTransformerAK4_B
  • DQMHistoSizes: changed ( 10224.0,... ): 23.738 KiB Btag/TagInfo_pfUnifiedParticleTransformerAK4_C
  • DQMHistoSizes: changed ( 10224.0,... ): 23.738 KiB Btag/TagInfo_pfUnifiedParticleTransformerAK4_L
  • DQMHistoSizes: changed ( 10224.0,... ): 11.008 KiB Btag/TagInfo_pfDeepFlavour_Inc
  • DQMHistoSizes: changed ( 10224.0 ): ...
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4b34cb into cms-sw:master Jan 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants