-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedup SiStripRecHitConverterAlgorithm by reserving the output size #47185
speedup SiStripRecHitConverterAlgorithm by reserving the output size #47185
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47185/43424 |
A new Pull Request was created by @slava77 for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
type performance-improvements |
this was motivated by inspection of
SiStripRecHitConverterAlgorithm
in the HLT context (runs without matching; expected to be used in HLT in combination with mkFit)initially, the cost of
shrink_to_fit
was the concern (5% of the converter). After adding reserve the overall speedup ofSiStripRecHitConverter::produce
is 14% (relative), which apparently benefits also from lack of reallocations.No changes are expected
@cms-sw/tracking-pog-l2 @cms-sw/trk-dpg-l2