Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedup SiStripRecHitConverterAlgorithm by reserving the output size #47185

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jan 25, 2025

this was motivated by inspection of SiStripRecHitConverterAlgorithm in the HLT context (runs without matching; expected to be used in HLT in combination with mkFit)

initially, the cost of shrink_to_fit was the concern (5% of the converter). After adding reserve the overall speedup of SiStripRecHitConverter::produce is 14% (relative), which apparently benefits also from lack of reallocations.

No changes are expected

@cms-sw/tracking-pog-l2 @cms-sw/trk-dpg-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 for master.

It involves the following packages:

  • RecoLocalTracker/SiStripRecHitConverter (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @alesaggio, @echabert, @felicepantaleo, @gbenelli, @gpetruc, @jlidrych, @missirol, @mmusich, @mtosi, @robervalwalsh, @rovere, @threus, @yduhm this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Jan 25, 2025

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bb2a3/43946/summary.html
COMMIT: c0f6383
CMSSW: CMSSW_15_0_X_2025-01-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47185/43946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 52
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3819013
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3441a18 into cms-sw:master Jan 27, 2025
11 checks passed
@mmusich
Copy link
Contributor

mmusich commented Jan 29, 2025

type performance-improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants