Add missing `#include` in `CondFormats/Common` #47240

fwyzard · 2025-02-02T15:38:11Z

PR description:

Add missing #include statement.

Fixes the error

src/CondFormats/Common/src/SmallWORMDict.cc: In constructor 'cond::SmallWORMDict::SmallWORMDict(const std::vector<std::__cxx11::basic_string<char> >&)':
src/CondFormats/Common/src/SmallWORMDict.cc:20:10: error: 'sort' is not a member of 'std'; did you mean 'qsort'?
   20 |     std::sort(m_index.begin(), m_index.end(), [&idict](unsigned int a, unsigned int b) {
      |          ^~~~

observed in the GCC 14 builds.

PR validation:

The code compiles.

fwyzard · 2025-02-02T15:38:19Z

please test

fwyzard · 2025-02-02T15:38:23Z

type bugfix

cmsbuild · 2025-02-02T15:38:32Z

cms-bot internal usage

cmsbuild · 2025-02-02T15:41:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47240/43524

cmsbuild · 2025-02-02T15:41:25Z

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

CondFormats/Common (db, alca)

@atpathak, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @seemasharmafnal, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-02-02T17:36:42Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5a997/44137/summary.html
COMMIT: cd5ee35
CMSSW: CMSSW_15_0_X_2025-02-02-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47240/44137/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4016938
DQMHistoTests: Total failures: 68
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4016850
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2025-02-03T08:18:31Z

CondFormats/Common/src/SmallWORMDict.cc

 #include <string>
 #include <functional>
 #include <numeric>
+#include <vector>


This is already included in the header, not needed to be repeated here:

Suggested change

#include <vector>

I can make the change, though I'm not fond of that approach, because if one removes the #include from the header then they have to update also the .cc file.

I can make the change, though I'm not fond of that approach, because if one removes the #include from the header then they have to update also the .cc file.

Thank you @fwyzard
Well, in this case both vector and string are only used as arguments of the class methods (or related to it): if the corresponding #includes's are removed from the header, it means that those methods will become completely different, and the .cc file would necessarily need to be modified in any case.

perrotta · 2025-02-03T08:19:30Z

CondFormats/Common/src/SmallWORMDict.cc

@@ -1,7 +1,10 @@
-#include "CondFormats/Common/interface/SmallWORMDict.h"
+#include <algorithm>
 #include <string>


Also this one, by the way

Suggested change

#include <string>

fwyzard · 2025-02-03T08:28:25Z

please test

cmsbuild · 2025-02-03T08:31:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47240/43526

cmsbuild · 2025-02-03T08:31:42Z

Pull request #47240 was updated. @atpathak, @consuegs, @francescobrivio, @perrotta can you please check and sign again.

cmsbuild · 2025-02-03T11:23:14Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5a997/44143/summary.html
COMMIT: 535a3bb
CMSSW: CMSSW_15_0_X_2025-02-02-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47240/44143/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4016938
DQMHistoTests: Total failures: 94
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4016824
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

fwyzard · 2025-02-03T13:46:49Z

Should be ready to sign.

cmsbuild · 2025-02-03T13:49:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47240/43538

cmsbuild · 2025-02-03T13:49:38Z

Pull request #47240 was updated. @atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please check and sign again.

perrotta · 2025-02-03T14:02:46Z

please test

perrotta · 2025-02-03T14:03:09Z

+1

cmsbuild · 2025-02-03T14:03:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2025-02-03T16:29:30Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5a997/44159/summary.html
COMMIT: a48a34f
CMSSW: CMSSW_15_0_X_2025-02-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47240/44159/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4016938
DQMHistoTests: Total failures: 69
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4016849
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: no differences found

mandrenguyen · 2025-02-03T17:30:38Z

+1

cmsbuild added this to the CMSSW_15_0_X milestone Feb 2, 2025

cmsbuild added alca-pending db-pending pending-signatures orp-pending tests-started bug-fix code-checks-pending labels Feb 2, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 2, 2025

cmsbuild added tests-approved and removed tests-started labels Feb 2, 2025

perrotta reviewed Feb 3, 2025

View reviewed changes

cmsbuild added tests-started code-checks-pending and removed tests-approved code-checks-approved labels Feb 3, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 3, 2025

cmsbuild removed the tests-started label Feb 3, 2025

fwyzard force-pushed the add_missing_include branch from 535a3bb to a48a34f Compare February 3, 2025 13:46

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Feb 3, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 3, 2025

cmsbuild added tests-started alca-approved fully-signed db-approved and removed tests-pending alca-pending db-pending pending-signatures labels Feb 3, 2025

cmsbuild added tests-approved and removed tests-started labels Feb 3, 2025

cmsbuild added orp-approved and removed orp-pending labels Feb 3, 2025

cmsbuild merged commit 79f5b6e into cms-sw:master Feb 3, 2025
11 checks passed

This was referenced Feb 4, 2025

libunwind master with fix for uninitialized access cms-sw/cmsdist#9639

Merged

[GCC14] template-id not allowed for constructor in C++20 #47265

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing `#include` in `CondFormats/Common` #47240

Add missing `#include` in `CondFormats/Common` #47240

fwyzard commented Feb 2, 2025

fwyzard commented Feb 2, 2025

fwyzard commented Feb 2, 2025

cmsbuild commented Feb 2, 2025 •

edited

Loading

cmsbuild commented Feb 2, 2025

cmsbuild commented Feb 2, 2025

cmsbuild commented Feb 2, 2025

perrotta Feb 3, 2025

fwyzard Feb 3, 2025

perrotta Feb 3, 2025

perrotta Feb 3, 2025

fwyzard commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

fwyzard commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

perrotta commented Feb 3, 2025

perrotta commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

mandrenguyen commented Feb 3, 2025

Add missing #include in CondFormats/Common #47240

Add missing #include in CondFormats/Common #47240

Conversation

fwyzard commented Feb 2, 2025

PR description:

PR validation:

fwyzard commented Feb 2, 2025

fwyzard commented Feb 2, 2025

cmsbuild commented Feb 2, 2025 • edited Loading

cmsbuild commented Feb 2, 2025

cmsbuild commented Feb 2, 2025

cmsbuild commented Feb 2, 2025

Comparison Summary

perrotta Feb 3, 2025

Choose a reason for hiding this comment

fwyzard Feb 3, 2025

Choose a reason for hiding this comment

perrotta Feb 3, 2025

Choose a reason for hiding this comment

perrotta Feb 3, 2025

Choose a reason for hiding this comment

fwyzard commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

Comparison Summary

fwyzard commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

perrotta commented Feb 3, 2025

perrotta commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

cmsbuild commented Feb 3, 2025

Comparison Summary

mandrenguyen commented Feb 3, 2025

Add missing `#include` in `CondFormats/Common` #47240

Add missing `#include` in `CondFormats/Common` #47240

cmsbuild commented Feb 2, 2025 •

edited

Loading