Fix the number for the last lumisection of the run

[fwyzard]

PR description:

Use edm::LuminosityBlockID::maxLuminosityBlockNumber() instead of edm::EventID::maxEventNumber() as the last luimisection number for the run.

Fixes the overflow errors reported by gcc 13 while testing the -fimplicit-constexpr option:

src/CondCore/CondDB/src/Time.cc: In function 'edm::IOVSyncValue cond::time::limitedIOVSyncValue(Time_t, TimeType)':
src/CondCore/CondDB/src/Time.cc:117:83: error: conversion from 'long long unsigned int' to 'edm::LuminosityBlockNumber_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
  117 |           return edm::IOVSyncValue(edm::EventID(time, edm::EventID::maxEventNumber(), edm::EventID::maxEventNumber()));
      |                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
src/CondCore/CondDB/src/Time.cc: In function 'edm::IOVSyncValue cond::time::limitedIOVSyncValue(const edm::IOVSyncValue&, TimeType)':
src/CondCore/CondDB/src/Time.cc:136:78: error: conversion from 'long long unsigned int' to 'edm::LuminosityBlockNumber_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow]
  136 |               edm::EventID(time.eventID().run(), edm::EventID::maxEventNumber(), edm::EventID::maxEventNumber()));
      |                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

PR validation:

The code compiles.

[fwyzard]

type bugfix

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47241/43525

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• CondCore/CondDB (db)

@atpathak, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14231f/44139/summary.html
COMMIT: 5c19154
CMSSW: CMSSW_15_0_X_2025-02-02-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47241/44139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 18 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4016938
• DQMHistoTests: Total failures: 26
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4016892
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+db

• Indeed, this looks like fixing in the code the calls of EventID(RunNumber_t iRun, LuminosityBlockNumber_t iLumi, EventNumber_t iEvent), whose second argument is actually expected to be a LuminosityBlockNumber_t and not a EventNumber_t

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1