add delayedStandAloneMuons to SA muon reco

[jalimena]

Adds displacedStandAloneMuons collection, intended to improve the pt bias for displaced muons reconstructed in the muon system only. Uses a combination of the cosmic seed and standalone trajectory building.

[cmsbuild]

A new Pull Request was created by @jalimena for CMSSW_7_2_X.

add delayedStandAloneMuons to SA muon reco

It involves the following packages:

RecoMuon/Configuration
RecoMuon/MuonSeedGenerator

@cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: 1c2116a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5178/823/summary.html

[abbiendi]

Hi all,

we have spotted a few things:
1.- there is a lacking "s" in the name of the seed collection in
RecoMuon/Configuration/python/RecoMuon_EventContent_cff.py
(should be "delayedMuonSeeds" or we have to change in the reco configuration...)

2.-As for the collection name, by interacting with Marco (in cc), it seems we could safely change the string "delayed" to "displaced" in the collection name, as it seems good also for in-time displaced muons, and it is clearer to everybody as said. Still for the moment we would prefer to keep the refitted STA muons, at least for a full RelVal cycle.

3.- the updated at vertex collection should NOT be made for this case, we forgot to set to "false" the proper parameter...

4.-I think we should save the segments in the seed (in the reco format), and then we could do the full validation also for the seeds (I was trying today...)

please Juliette, could you take care of 1. and 2. ?
Daniele will suggest how to correct for 3. and 4.-

For info, I have also been updating the muon validation to include the new muon collection.
I have the code in my area (not yet pushed in git), it works, but I tested it only on few events by now.

cheers
Giovanni

[jalimena]

Ok hopefully my new commit has correctly taken care of 1 and 2.

For #4, I think Daniele did it for me some time ago when we thought it was necessary:
https://github.com/trocino/cmssw/tree/CosmicSeedWithSegments/RecoMuon/MuonSeedGenerator
Unless I misunderstand what you are talking about.

Please let me know if there is any problem.

[cmsbuild]

Pull request #5178 was updated. @cmsbuild, @nclopezo, @StoyanStoynev, @slava77 can you please check and sign again.

[abbiendi]

thanks Juliette, ok 1. and 2.
For the segments I think you understand correctly. However I would wait for a fix from Daniele to skip the update at vertex for this sequence. We tried it before but still an empty collection was written that is not nice... hope he will reply soon.

[trocino]

Hi Juliette,

yes, that is the code you need for item 4. You already used it in the past, so it's safe. I asked you to remove it because it wasn't strictly necessary without the ExhaustiveTracjectoryBuilder. But it can still come in handy for validation, so we'd better put it back in.

As for item 3, the main thing is to add in
RecoMuon/Configuration/python/RecoMuonPPonly_cff.py
the following line:
displacedStandAloneMuons.TrackLoaderParameters.VertexConstraint = cms.bool(False)
This should added around line 20-21, where you customize "displacedStandAloneMuons".
With this change the update at vertex is not performed, but an empty collection
'recoTracks_displacedStandAloneMuons_UpdatedAtVtx_'
is still put in the event, I can't figure out why, I must be missing something in the code (1).
It can be avoided by changing the event content: at line 52 of
RecoMuon/Configuration/python/RecoMuon_EventContent_cff.py
you can change
'keep recoTracks_displacedStandAloneMuons__'
to
'keep recoTracks_displacedStandAloneMuons__'
But it's just a workaround, there must be a clean way to do it from the code, I just can't see it now.
Riccardo or Slava can certainly help with this.

Thanks, Daniele

(1) https://github.com/cms-sw/cmssw/blob/CMSSW_7_2_X/RecoMuon/TrackingTools/src/MuonTrackLoader.cc

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5178/877/summary.html

[StoyanStoynev]

@deguio any issues concerning the validation part?

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

[StoyanStoynev]

The promised wf 202 (ttbar with PU):

new modules run:
displacedMuonSeeds 0.21776 ms/ev
displacedStandAloneMuons 10.4964 ms/ev

new branches in the event:

Branch Name | Average Compressed Size (Bytes/Event)

new: TrajectorySeeds_displacedMuonSeeds__RECO. 1625.96
new: TrackingRecHitsOwned_displacedStandAloneMuons__RECO. 1262.69
new: recoTrackExtras_displacedStandAloneMuons__RECO. 190.745
new: recoTracks_displacedStandAloneMuons__RECO. 112.825