Moved functionality from OutputWorker to OutputModuleCommunicator #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Schedule class was doing a dynamic_cast<OutputWorker> on all workers in order to communicate with the OutputModule. This will not work when we go to the threaded framework since there will be several different OutputModule types with different workers. The solution was to abstract the communication with the OutputModule into a OutputModuleCommunication base class.
The Schedule class had conflicts since the recent topic cms-sw#36 moved Worker handling into a WorkerManager class and out of Schedule. This merge reconciles that change with the change to use an OutputModuleCommunicator class. Conflicts: FWCore/Framework/interface/Schedule.h FWCore/Framework/src/Schedule.cc
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
|
@nclopezo can you try this out? |
|
Hi, I took CMSSW_7_0_X_2013-07-08-0200 pulled these changes with cms-merge-topic and ran the unit tests and RelVals tests. All the tests passed for FWCore/Framework |
|
Did you run runTheMatrix -s? |
|
Yes I did Sent from Samsung Mobile -------- Original message -------- Did you run runTheMatrix -s? |
ktf
added a commit
that referenced
this pull request
Jul 8, 2013
Moved functionality from OutputWorker to OutputModuleCommunicator
jshlee
referenced
this pull request
in jshlee/cmssw
Dec 19, 2013
Adding harvesting code for SIM and DIGI and changing cmsDriver option.
nclopezo
added a commit
to nclopezo/cmssw
that referenced
this pull request
May 5, 2014
It now looks for hlt tests restuls for 70X,62X and 53X
gpetruc
pushed a commit
to gpetruc/cmssw
that referenced
this pull request
Jul 2, 2015
mt2 cfg file: add data files; add switch to run on data
yetkinyilmaz
pushed a commit
to yetkinyilmaz/cmssw
that referenced
this pull request
Jan 27, 2016
…hesforl1 added two missing L1 branches to dummybranches
jbsauvan
added a commit
to jbsauvan/cmssw
that referenced
this pull request
Oct 6, 2016
Fix reset in HGCalTriggerGeometryHexImp2 in pre9
mariadalfonso
pushed a commit
to mariadalfonso/cmssw
that referenced
this pull request
May 6, 2017
Synchronization
cmsbuild
pushed a commit
that referenced
this pull request
Jul 26, 2017
…rips Customization for phase2
arizzi
added a commit
to rappoccio/cmssw
that referenced
this pull request
Oct 31, 2017
add genpart mass and x1,x2
makortel
added a commit
to makortel/cmssw
that referenced
this pull request
May 25, 2018
- load CUDAService to ConfigBuilder - add support for product label - silence callback printout Eventually we need more general config file containing all device services.
tahuang1991
pushed a commit
to tahuang1991/cmssw
that referenced
this pull request
Aug 23, 2018
…numbering_Tao From cmssw 10 2 1 me1a numbering tao
Jingyan95
pushed a commit
to Jingyan95/cmssw
that referenced
this pull request
Nov 18, 2020
* fix and add variables for default model * change parameters to new default model * fix code formatting
tomalin
pushed a commit
to tomalin/cmssw
that referenced
this pull request
Dec 7, 2020
* fix and add variables for default model * change parameters to new default model * fix code formatting
tomalin
pushed a commit
to tomalin/cmssw
that referenced
this pull request
Jan 5, 2021
* fix and add variables for default model * change parameters to new default model * fix code formatting
gpetruc
added a commit
to gpetruc/cmssw
that referenced
this pull request
Apr 14, 2021
…irmware Bring EM interpretation to 11_1_7 branch
franzoni
pushed a commit
to franzoni/cmssw
that referenced
this pull request
May 3, 2021
* Fix the import of weights * Update README.md
dsrankin
pushed a commit
to dsrankin/cmssw
that referenced
this pull request
Mar 9, 2022
Save PF and Puppi candidates
hqucms
pushed a commit
to hqucms/cmssw
that referenced
this pull request
Sep 18, 2023
…O-13_2_0_pre3_patch Add single module condition for LD run + fix econdErx and updated NANO format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Schedule class was doing a dynamic_cast on all workers in order to communicate with the OutputModule. This will not work when we go to the threaded framework since there will be several different OutputModule types with different workers. The solution was to abstract the communication with the OutputModule into a OutputModuleCommunication base class.