Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validationfor mc m #93

Closed
wants to merge 27 commits into from
Closed

Validationfor mc m #93

wants to merge 27 commits into from

Conversation

inugent
Copy link
Contributor

@inugent inugent commented Jul 13, 2013

Pull request required to update Validation package for McM

@cmsbuild
Copy link
Contributor

The following categories have been signed by ciulli (a.k.a. @vciulli on GitHub): Generators

@cms-git-generators

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2013

The following categories have been signed by ciulli (a.k.a. @vciulli on GitHub): Generators

@cms-git-generators

@davidlt
Copy link
Contributor

davidlt commented Sep 2, 2013

@inugent @vciulli This does not merge on top of CMSSW_4_4_5_patch4. Part of that is due to CVS keywords. Could you look into it?

export SCRAM_ARCH=slc5_amd64_gcc434
scram p CMSSW_4_4_5_patch4
cd CMSSW_4_4_5_patch4
eval $(scram r -sh)
git cms-merge-topic 93

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

@inugent
Copy link
Contributor Author

inugent commented Sep 6, 2013

Hello,
I have update the commits to remove conflicts cause by the CVS
time-stamps. However there are still 4 conflicts related to the code.
These changes are patches to the code. Best regards,
Ian

On 9/2/2013 1:58 AM, davidlt wrote:

@inugent https://github.com/inugent @vciulli
https://github.com/vciulli This does not merge on top of
|CMSSW_4_4_5_patch4|. Part of that is due to CVS keywords. Could you
look into it?

|export SCRAM_ARCH=slc5_amd64_gcc434
scram p CMSSW_4_4_5_patch4
cd CMSSW_4_4_5_patch4
eval $(scram r -sh)
git cms-merge-topic 93
|


Reply to this email directly or view it on GitHub
#93 (comment).

Dr. Ian M. Nugent
Humboldt Fellow
III. Physikalisches Institut B
RWTH Aachen, D-52056 Aachen
Tel: +49 241 80-27290
Email: nugent@physik.rwth-aachen.de

@vciulli
Copy link
Contributor

vciulli commented Sep 6, 2013

Hi Ian. The conflicts are due to changes done in the HEAD with respect to the version you worked on. In some case it looks straightforward to fix the code. Can't you try to resolve the conflicts and update the pull?

@inugent
Copy link
Contributor Author

inugent commented Sep 11, 2013

This pull request was superseded by pull request 168

@inugent inugent closed this Sep 11, 2013
jshlee referenced this pull request in jshlee/cmssw Mar 4, 2014
nclopezo added a commit to nclopezo/cmssw that referenced this pull request Nov 21, 2014
Reports also changes between 2 releases in cmsdist
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Nov 23, 2014
gdimperi pushed a commit to gdimperi/cmssw that referenced this pull request Jun 21, 2015
…-of-nll-in-discrete-nuisance-fit

Change of sign in check for fit result change.
jpata pushed a commit to jpata/cmssw that referenced this pull request Jul 13, 2015
Automatic das query to update dataset list
MiheeJo pushed a commit to MiheeJo/cmssw that referenced this pull request Nov 14, 2016
mariadalfonso pushed a commit to mariadalfonso/cmssw that referenced this pull request May 6, 2017
multi primary datasets and drawSyst
rappoccio pushed a commit to rappoccio/cmssw that referenced this pull request Jan 18, 2018
…onForNanoWith80X

Tune trigger filter and collection names to 2016 settings
mbluj added a commit to mbluj/cmssw that referenced this pull request Oct 17, 2018
tomalin added a commit to tomalin/cmssw that referenced this pull request Oct 24, 2021
* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* small script modifications

* little ntuple maker mod.

* readding fake fit config interface.

* track tigger association added, not in the best way.

* tttrack associator added as it should be.

* option to use TTStubAssMap to associate TTTracks with TPs removed and output module cleaned up.

* Added Hybrid_NewKF

* Added comment

* Update L1TrackNtupleMaker_cfg.py

fix typo made by Ian

* added tmtt costumization and fakefit option to tracklet config

* data format fix

* README filled and Configuration.StandardSequences.L1TrackTrigger_cff removed from run scripts.

* associateFinal added to StubAssociation.

* Update README.md

English corrections

* minor changes in various comments.

* KF 7 layer tracking debugged and defaulted.

* turned supported geometry white list into a black list.

* Cbrown kfout (cms-sw#93)

* Initial Commit for Kfout emulator

* with ttTrackRefMap back in

* Correct link structure and eta routing

* No more print statements

* Remove print statements

* Merge changes in kfout producer

* Thomas' comments #1

* Thomas' comments cms-sw#2

* Change dphi/dz LUT scaling to num of bits

* Fix bug to phi sector correction

* sync with FW fix

* Commit of distribution server for clock accuracy

* Fix to undefined operation on numLinkTracks

* Fix to numLinkTracks cms-sw#2

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Chriisbrown <41648127+Chriisbrown@users.noreply.github.com>
cmsbuild pushed a commit that referenced this pull request May 11, 2022
sarafiorendi pushed a commit to sarafiorendi/cmssw that referenced this pull request Jun 10, 2022
* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* small script modifications

* little ntuple maker mod.

* readding fake fit config interface.

* track tigger association added, not in the best way.

* tttrack associator added as it should be.

* option to use TTStubAssMap to associate TTTracks with TPs removed and output module cleaned up.

* Added Hybrid_NewKF

* Added comment

* Update L1TrackNtupleMaker_cfg.py

fix typo made by Ian

* added tmtt costumization and fakefit option to tracklet config

* data format fix

* README filled and Configuration.StandardSequences.L1TrackTrigger_cff removed from run scripts.

* associateFinal added to StubAssociation.

* Update README.md

English corrections

* minor changes in various comments.

* KF 7 layer tracking debugged and defaulted.

* turned supported geometry white list into a black list.

* Cbrown kfout (cms-sw#93)

* Initial Commit for Kfout emulator

* with ttTrackRefMap back in

* Correct link structure and eta routing

* No more print statements

* Remove print statements

* Merge changes in kfout producer

* Thomas' comments cms-sw#1

* Thomas' comments cms-sw#2

* Change dphi/dz LUT scaling to num of bits

* Fix bug to phi sector correction

* sync with FW fix

* Commit of distribution server for clock accuracy

* Fix to undefined operation on numLinkTracks

* Fix to numLinkTracks cms-sw#2

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Chriisbrown <41648127+Chriisbrown@users.noreply.github.com>
sarafiorendi pushed a commit to sarafiorendi/cmssw that referenced this pull request Jun 13, 2022
* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* small script modifications

* little ntuple maker mod.

* readding fake fit config interface.

* track tigger association added, not in the best way.

* tttrack associator added as it should be.

* option to use TTStubAssMap to associate TTTracks with TPs removed and output module cleaned up.

* Added Hybrid_NewKF

* Added comment

* Update L1TrackNtupleMaker_cfg.py

fix typo made by Ian

* added tmtt costumization and fakefit option to tracklet config

* data format fix

* README filled and Configuration.StandardSequences.L1TrackTrigger_cff removed from run scripts.

* associateFinal added to StubAssociation.

* Update README.md

English corrections

* minor changes in various comments.

* KF 7 layer tracking debugged and defaulted.

* turned supported geometry white list into a black list.

* Cbrown kfout (cms-sw#93)

* Initial Commit for Kfout emulator

* with ttTrackRefMap back in

* Correct link structure and eta routing

* No more print statements

* Remove print statements

* Merge changes in kfout producer

* Thomas' comments cms-sw#1

* Thomas' comments cms-sw#2

* Change dphi/dz LUT scaling to num of bits

* Fix bug to phi sector correction

* sync with FW fix

* Commit of distribution server for clock accuracy

* Fix to undefined operation on numLinkTracks

* Fix to numLinkTracks cms-sw#2

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Chriisbrown <41648127+Chriisbrown@users.noreply.github.com>
cmsbuild pushed a commit that referenced this pull request Oct 13, 2022
Include commit from fw_synch_210611 (#86)

* Fixes to remove unused TPROJ memory and fix problem with VMR LUT in L6

* apply code-formats and code-checks

Co-authored-by: Anders <aryd@cern.ch>

Update Settings.h (#89)

TE truncation reduced from 108 to 107, as requested in cms-L1TK#85

Update geometry and MC files (#91)

L1 tk dev 12 0 0 pre4 hph (#94)

* First Commit

* Code Format

* Fix Typo

* Naming Rule

* Chris' 2nd Comment

Co-authored-by: Jack Li <jingyan.li@cern.ch>

Reduced configuration (#87)

* Modified code to support a reduced config (the summer chain)

* Updates from running code checker.

* Reverted to standard configuration options.

* Reverted to standard configuration options.

* Settings used to make TV for event 1912

* Reverted to default settings for PR.

* Made some of the TV changes in issue 85, and created output TVs 2021-08-04-TTbar-SimpleFWHarmonization.

* Clarified comments

* Include commit from fw_synch_210611 (#86)

* Fixes to remove unused TPROJ memory and fix problem with VMR LUT in L6

* apply code-formats and code-checks

Co-authored-by: Anders <aryd@cern.ch>

* Returning to standard config.

* Returning to standard config.

* Returning to standard config.

* Update geometry and MC files (#91)

* Included reduced variable in non-reduced setups for consistency.

* Updated settings to match default configuration rather than HLS compatibility

* Added comment about reduced config files

Co-authored-by: Tova Holmes <tholmes@cern.ch>
Co-authored-by: Louise Skinnari <louise.skinnari@cern.ch>
Co-authored-by: Anders <aryd@cern.ch>
Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Revert "L1 tk dev 12 0 0 pre4 hph (#94)" (#95)

This reverts commit 3b2f139.

fix getPhiRes function (#97)

New KF (hand merged with L1TK-dev-12_0_0_pre4) (#88)

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* small script modifications

* little ntuple maker mod.

* readding fake fit config interface.

* track tigger association added, not in the best way.

* tttrack associator added as it should be.

* option to use TTStubAssMap to associate TTTracks with TPs removed and output module cleaned up.

* Added Hybrid_NewKF

* Added comment

* Update L1TrackNtupleMaker_cfg.py

fix typo made by Ian

* added tmtt costumization and fakefit option to tracklet config

* data format fix

* README filled and Configuration.StandardSequences.L1TrackTrigger_cff removed from run scripts.

* associateFinal added to StubAssociation.

* Update README.md

English corrections

* minor changes in various comments.

* KF 7 layer tracking debugged and defaulted.

* turned supported geometry white list into a black list.

* Cbrown kfout (#93)

* Initial Commit for Kfout emulator

* with ttTrackRefMap back in

* Correct link structure and eta routing

* No more print statements

* Remove print statements

* Merge changes in kfout producer

* Thomas' comments #1

* Thomas' comments #2

* Change dphi/dz LUT scaling to num of bits

* Fix bug to phi sector correction

* sync with FW fix

* Commit of distribution server for clock accuracy

* Fix to undefined operation on numLinkTracks

* Fix to numLinkTracks #2

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Chriisbrown <41648127+Chriisbrown@users.noreply.github.com>

fix of KFin EnableTruncation option. (#99)

* quick fix of KFin EnableTruncation option.

* both, enable and disabel truncation fixed.

Fix to KF out for multiple KF workers (#100)

code-format, llvm-ccdb and clang-tidy (#103)

Fixed clang errors (#104)

several bug fixes. (#108)

* bug fixes.

* code format

* GlobalTag update.

* forgot a bug fix in AnalyzerDemonstrator.

add number of TTCluster to DTC analzyer end job summary (#109)

* count of TTCluster added to endjob summary printout.

* rebase to L1TK-dev-12_0_0_pre4 and code format.

Added git CI (#106)

* Added git CI

* Run CI on PR to any branch

* Make L1TRKALGO configurable

* tweak

* Added script to skim MC datasets for git CI

* Remove L1TRKALGO option

* Gave CI more sensible name

Update github_CI.yml

temporary debug check

Memory cleanup (#98)

* Cleanup of writing leading 0x in memories

* Cleanup of obsolote comment

* Change order of input links to match VMRouter expectation

* Add support for debugging

* Remove one pipelining step to match HLS

* Determine the PS vs 2S in disks same way as we do in HLS

* Some cleanup

* Correction to LUT code

* Comment out printout

* Ran scram build code-format

* Update comment about IR steps

* Cleanup of obsolote comment

* Remove one pipelining step to match HLS

* Determine the PS vs 2S in disks same way as we do in HLS

* Correction to LUT code

* Ran scram build code-format

phiprojder bug fix (#116)

Channel Assignment TrackBuilder output Tracks + Stubs and InputRouter input Stubs (#110)

* track builder channel upgraded to assign stubs to channel.

* code format

* readded missing pieces.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* name change in L1Trigger/TrackFindingTracklet/python/ProducerKF_cff.py

* bug fix

* name change of config parameter

* code-format

* namespace change and consitency check added.

* addressing ians comments

* addressing ians comments

TP_minPt and binning fix (#118)

Updated VMR maxstep to 107 (originally 108) to match firmware (#119)

Minor improvements (#120)

* Minor improvements

* Added comments

Dropped MC to 104 iterations (#123)

- Full agreement with HLS

Fixing integer range check in FPGAWord. (#125)

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

* Fix < to <= to avoid overflow by one

Co-authored-by: Brent R. Yates <brentRyates@gmail.com>
Co-authored-by: Anders <aryd@cern.ch>

Fix KF Track Parameter Digitization (#127)

* Fix KF Track Parameter Digitization

* Add comments to Track.h

summer chain demonstrator (#111)

* track builder channel upgraded to assign stubs to channel.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* ProducerIRin and ProducerTBout added, Demonstrator configured by default to use them.

* rebase with tschuh_TrackBuilder and code format

* StreamsStub added as EDProduct of L1FPGATrackProducer

* code format.

* convert only finally accepted Tracklets to StreamsStub.

* undo last commit, adding trackword ed product and adding gaps to stubs and tracks to get clock accurate emulation.

* swap bugfix.

* rebased and name change of TrackBuilderChannel adopted.

* fixing rebase errors.

* fixing more rebase errors.

* fixing even more rebase errors.

* first comments from Ian.

* code format

* second comments from Ian.

* code format

* Ians third comments.

* Ians 4th comments.

* small merge error fix

* Added comment

* Refine comment

* miniscule comment change

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Fixed comparisons to avoid overflow. (#128)

MP HLS agreement fixes (#126)

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Fixes to get agreement with HLS code

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

Co-authored-by: Brent R. Yates <brentRyates@gmail.com>
Co-authored-by: Thomas Schuh <thomas.schuh@stfc.ac.uk>

Update Settings.h (#130)

Fix "storeTrackBuilderOutput_" typo

Update Setup.cc (#129)

Change trackerDTC::Setup to tt::Setup . (Bug fix)

Update LayerEncoding.h (#131)

* Update LayerEncoding.h

Add function to access layer corresponding to given DTC channel. (Needed by L1Trk Future CMSSW code).

* Update LayerEncoding.h

response to comment + fix to previous commit

* Update LayerEncoding.cc

Initialize data member numDTCsPerRegion_

* Update LayerEncoding.h

added comment

* Update LayerEncoding.h

clarified comment

Test vector fixes (#132)

* Made eventProcessor a member of the producer.

* Output TC tables in the reduced config.

MP cleanup 220208 + MC fix (#133)

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Some updates to MP to converge with HLS code

* Further clenup of the MP code

* More cleanup -removal of hardcoded numbers

* Further cleanup

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

* Some updates to MP to converge with HLS code

* Further clenup of the MP code

* More cleanup -removal of hardcoded numbers

* Further cleanup

* Fixes to the MC to allow full agreement with HLS

* Added a comment header and pipeline description

* Added comment about MC iterations

Co-authored-by: Thomas Schuh <thomas.schuh@stfc.ac.uk>
Co-authored-by: Anders <aryd@cern.ch>

customize L1FPGATrackProducer (#112)

* track builder channel upgraded to assign stubs to channel.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* StreamsStub added as EDProduct of L1FPGATrackProducer

* code format.

* convert only finally accepted Tracklets to StreamsStub.

* undo last commit, adding trackword ed product and adding gaps to stubs and tracks to get clock accurate emulation.

* swap bugfix.

* rebased and name change of TrackBuilderChannel adopted.

* fixing rebase errors.

* fixing more rebase errors.

* fixing even more rebase errors.

* track builder channel upgraded to assign stubs to channel.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* StreamsStub added as EDProduct of L1FPGATrackProducer

* rebased and name change of TrackBuilderChannel adopted.

* criteria to build track updated, TBout works now for all seed types.

* StreamsStub added as EDProduct of L1FPGATrackProducer

* use customize function to manipulate L1FPGATrackProducer configuration

* rebase to tschuh_SummerChain, customize updated to set EmulateTB, demonstrator counts now the amount of passed events.

* initial counter values fixed.

* rebase and reduce config customize function extended

* fixing merge errors.

* Ians first comments.

* rebase and Ians secodn comments.

* Update ChannelAssignment_cfi.py

* Ians third comments.

* Ians fourth comments.

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Update Customize_cff.py (#135)

TBout analyzer (#114)

* Reviewed.

* one merge error fixed, but a problem remains

* fixed second error.

* Update AnalyzerTBout.cc

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Fix d0 bias (#124)

* Fix d0 bias

* Documented KF maths and variables

Ian tidy up (#137)

* Added function to convert ATCA slot to DTC name

* Moved dtcname to Settings.h and put underscore at end of settings

* Declared functions const if dont change data members

* Added comments to clarify params overridden by python cfg

* Added comment

* Removed duplicate function TCNAme

disable truncation for displaced tracking (#142)

DTC phi range hard-wired constants removed (#141)

* Added function to get num ATCA slots

* Added comment

* Automatically calc DTC phi ranges

* Improved comments

* Added comment

* Simplified phi offset calc

* Fixed missing half-sector rotation bug

* Added comments

* Changed dtcphirange.txt to numbers instead of C++ code

Displaced tracking phi fix (#147)

* usephiapprox on modify NtupleMaker cfg for grid jobs

* added displaced terms to phi calculation in TrackletCalculatorDisplaced

* reverting changes unrelated to phi correction

Jack hph (#146)

* First Commit

* Code Format

* Fix Typo

* Naming Rule

* Chris' 2nd Comment

* Fixing Bug

* Ian's 1st Comments

* Ian's 2nd Comment: Remove SensorModule Class

* Ian's 3rd comment: Get rid of magic numbers

* Ian's 4th Comment: Add more clarification

* Code-check

Co-authored-by: Jack Li <jingyan.li@cern.ch>

Adding new features to ntuplemaker (#148)

Co-authored-by: Jack Li <jingyan.li@cern.ch>

Update StubAssociation.cc (#145)

as requested a separate PR.

Update github_CI.yml

Fixed incorrect comment

KFin emulator (#143)

* initial commit.

* move ProducerTBout.cc from test to plugins

* KFin fully debugged.

* Producer TBout added to NTupleMaker

* chriss change to KFout

* Louises first comments.

* fixing rebase errors.

* KF reintegrated, stub residuals are not bit accurate yet.

* code format.

* added 1k ttbar@0PU events for internal kf maths tuning.

* Track builder r residual debug and KF digi function corrected.

* bug in z residual base fixed.

* Ians first comments.

* Ians secodn comments.

* recalculate z ressid from TTStubRefs, use TTStubRefs for seed stubs instead of fake stubs.

* Ians third comment.

* fixed comments TTDTC::Frames -> tt::Frames

* old stub uncertainty caclulation re-enabled.

* Ians 4th comments.

* code-checks.

* tilted stub z uncertainty fixed. not yet debugged against f/w.

* set max layers a kff adds to a track to 7 as we did in the past, no clue why it is 4 again ...

* agrrement with f/w, ready to merge.

Fix rare crash in KF (#151)

* Fix rare crash in KF

* Fixed line break

Removed obsolete parameter. (#152)

quick ntuple fix (#153)

* L1TrackNtupleMaker_cfg.py updated reduced workflow.

* further cleaning.

Update L1TrackNtupleMaker_cfg.py

fixed typo

Removal of dependencies of ChannelAssignement (#144)

* This code includes a new implementation of the Track and Stub Streams generation. The old code is still running in parallel.

* Remove code for old calculation of stream data - keeping the debug print out in this commit

* Remove debud printout

* added numSeedTypes function

* rebased Anders branch

* rebased Anders branch

* tidied up Anders branch

* tidied up Anders branch

* ran scram b code-format

* Thomas PR review comments

* max num of proj layers added to channel assignment.

* merge with Thomas commit

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Thomas Schuh <thomas.schuh@stfc.ac.uk>

Ran second auto formatter tool (#154)

* Ran second auto formatter tool

* tweak

Update ProducerSetup_cfi.py

correct comment in code

Update Customize_cff.py

add comment in code

Tracklet Processor Displaced (#159)

* Tracklet Processor Displaced

* code-format

* code-format again

* remove unnecessary comments and add explanation for header file

* implement more comments

* remove more magic numbers

Update track quality chi2 bins (#161)

* update chi2 bins

* change chi2 variables to be per dof

Ian L1TStub bug fix (#160)

* Ran second auto formatter tool

* tweak

* Fixed bug in L1TStub::isTilted function

* Update L1TrackNtupleMaker_cfg.py

Removed unnecessary line

* Update L1FPGATrackProducer.cc

Fix incorrect tiltedBarrel variable in endcap

rebase and scram b code-format

ran formatter tool 2

tweak

Update chi2 tq bins (#165)

* change binning method used by track quality

* clean TrackQuality class to only create features used by default classifier

* ran scram b -j8 clang-format

Added tilted and endcap module ring no. to L1TStub (#166)

* Added tilted and endcap module ring no. to L1TStub

* auto formatting

Fix stub order bug (#164)

* fix to stub order bug

* fix to stub order bug

* Updated to one::EDAnalyzer

* ran scram b code format

* Fixed bug for combined modules

Update MatchCalculator.cc

Added comment.

rebase git conflict resolution

rebase git conflict resolution

rebase git conflict resolution

Remove obsolete FWCore functions (#168)

Updated data/ files

tweak

Reduce L1 tracking CPU (#172)

* Reduce CPU use

* Reduce CPU

* Reduce CPU

* Added track quality plots

* updated geom

* Trivial variable renames

* Moved RunTime call to constructor to save CPU

* Removed debug calcs from VarBase::calculate

* Optimised a bit more VarBase::calculate

* optimise CPU further

* auto format

Update L1TrackNtupleMaker.cc

Restored consumes<TrackingVertex>. Not required, but keeps CPU expensive loading of TrackingVertexCollection where it was to make CPU comparisons easier.

Removed CI .yml files & data/ directory to allow PR to central CMSSW
cramonal pushed a commit to cramonal/cmssw that referenced this pull request Nov 14, 2022
Include commit from fw_synch_210611 (cms-sw#86)

* Fixes to remove unused TPROJ memory and fix problem with VMR LUT in L6

* apply code-formats and code-checks

Co-authored-by: Anders <aryd@cern.ch>

Update Settings.h (cms-sw#89)

TE truncation reduced from 108 to 107, as requested in cms-L1TK#85

Update geometry and MC files (cms-sw#91)

L1 tk dev 12 0 0 pre4 hph (cms-sw#94)

* First Commit

* Code Format

* Fix Typo

* Naming Rule

* Chris' 2nd Comment

Co-authored-by: Jack Li <jingyan.li@cern.ch>

Reduced configuration (cms-sw#87)

* Modified code to support a reduced config (the summer chain)

* Updates from running code checker.

* Reverted to standard configuration options.

* Reverted to standard configuration options.

* Settings used to make TV for event 1912

* Reverted to default settings for PR.

* Made some of the TV changes in issue 85, and created output TVs 2021-08-04-TTbar-SimpleFWHarmonization.

* Clarified comments

* Include commit from fw_synch_210611 (cms-sw#86)

* Fixes to remove unused TPROJ memory and fix problem with VMR LUT in L6

* apply code-formats and code-checks

Co-authored-by: Anders <aryd@cern.ch>

* Returning to standard config.

* Returning to standard config.

* Returning to standard config.

* Update geometry and MC files (cms-sw#91)

* Included reduced variable in non-reduced setups for consistency.

* Updated settings to match default configuration rather than HLS compatibility

* Added comment about reduced config files

Co-authored-by: Tova Holmes <tholmes@cern.ch>
Co-authored-by: Louise Skinnari <louise.skinnari@cern.ch>
Co-authored-by: Anders <aryd@cern.ch>
Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Revert "L1 tk dev 12 0 0 pre4 hph (cms-sw#94)" (cms-sw#95)

This reverts commit 3b2f139.

fix getPhiRes function (cms-sw#97)

New KF (hand merged with L1TK-dev-12_0_0_pre4) (cms-sw#88)

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* small script modifications

* little ntuple maker mod.

* readding fake fit config interface.

* track tigger association added, not in the best way.

* tttrack associator added as it should be.

* option to use TTStubAssMap to associate TTTracks with TPs removed and output module cleaned up.

* Added Hybrid_NewKF

* Added comment

* Update L1TrackNtupleMaker_cfg.py

fix typo made by Ian

* added tmtt costumization and fakefit option to tracklet config

* data format fix

* README filled and Configuration.StandardSequences.L1TrackTrigger_cff removed from run scripts.

* associateFinal added to StubAssociation.

* Update README.md

English corrections

* minor changes in various comments.

* KF 7 layer tracking debugged and defaulted.

* turned supported geometry white list into a black list.

* Cbrown kfout (cms-sw#93)

* Initial Commit for Kfout emulator

* with ttTrackRefMap back in

* Correct link structure and eta routing

* No more print statements

* Remove print statements

* Merge changes in kfout producer

* Thomas' comments #1

* Thomas' comments cms-sw#2

* Change dphi/dz LUT scaling to num of bits

* Fix bug to phi sector correction

* sync with FW fix

* Commit of distribution server for clock accuracy

* Fix to undefined operation on numLinkTracks

* Fix to numLinkTracks cms-sw#2

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Chriisbrown <41648127+Chriisbrown@users.noreply.github.com>

fix of KFin EnableTruncation option. (cms-sw#99)

* quick fix of KFin EnableTruncation option.

* both, enable and disabel truncation fixed.

Fix to KF out for multiple KF workers (cms-sw#100)

code-format, llvm-ccdb and clang-tidy (cms-sw#103)

Fixed clang errors (cms-sw#104)

several bug fixes. (cms-sw#108)

* bug fixes.

* code format

* GlobalTag update.

* forgot a bug fix in AnalyzerDemonstrator.

add number of TTCluster to DTC analzyer end job summary (cms-sw#109)

* count of TTCluster added to endjob summary printout.

* rebase to L1TK-dev-12_0_0_pre4 and code format.

Added git CI (cms-sw#106)

* Added git CI

* Run CI on PR to any branch

* Make L1TRKALGO configurable

* tweak

* Added script to skim MC datasets for git CI

* Remove L1TRKALGO option

* Gave CI more sensible name

Update github_CI.yml

temporary debug check

Memory cleanup (cms-sw#98)

* Cleanup of writing leading 0x in memories

* Cleanup of obsolote comment

* Change order of input links to match VMRouter expectation

* Add support for debugging

* Remove one pipelining step to match HLS

* Determine the PS vs 2S in disks same way as we do in HLS

* Some cleanup

* Correction to LUT code

* Comment out printout

* Ran scram build code-format

* Update comment about IR steps

* Cleanup of obsolote comment

* Remove one pipelining step to match HLS

* Determine the PS vs 2S in disks same way as we do in HLS

* Correction to LUT code

* Ran scram build code-format

phiprojder bug fix (cms-sw#116)

Channel Assignment TrackBuilder output Tracks + Stubs and InputRouter input Stubs (cms-sw#110)

* track builder channel upgraded to assign stubs to channel.

* code format

* readded missing pieces.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* name change in L1Trigger/TrackFindingTracklet/python/ProducerKF_cff.py

* bug fix

* name change of config parameter

* code-format

* namespace change and consitency check added.

* addressing ians comments

* addressing ians comments

TP_minPt and binning fix (cms-sw#118)

Updated VMR maxstep to 107 (originally 108) to match firmware (cms-sw#119)

Minor improvements (cms-sw#120)

* Minor improvements

* Added comments

Dropped MC to 104 iterations (cms-sw#123)

- Full agreement with HLS

Fixing integer range check in FPGAWord. (cms-sw#125)

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

* Fix < to <= to avoid overflow by one

Co-authored-by: Brent R. Yates <brentRyates@gmail.com>
Co-authored-by: Anders <aryd@cern.ch>

Fix KF Track Parameter Digitization (cms-sw#127)

* Fix KF Track Parameter Digitization

* Add comments to Track.h

summer chain demonstrator (cms-sw#111)

* track builder channel upgraded to assign stubs to channel.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* ProducerIRin and ProducerTBout added, Demonstrator configured by default to use them.

* rebase with tschuh_TrackBuilder and code format

* StreamsStub added as EDProduct of L1FPGATrackProducer

* code format.

* convert only finally accepted Tracklets to StreamsStub.

* undo last commit, adding trackword ed product and adding gaps to stubs and tracks to get clock accurate emulation.

* swap bugfix.

* rebased and name change of TrackBuilderChannel adopted.

* fixing rebase errors.

* fixing more rebase errors.

* fixing even more rebase errors.

* first comments from Ian.

* code format

* second comments from Ian.

* code format

* Ians third comments.

* Ians 4th comments.

* small merge error fix

* Added comment

* Refine comment

* miniscule comment change

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Fixed comparisons to avoid overflow. (cms-sw#128)

MP HLS agreement fixes (cms-sw#126)

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Fixes to get agreement with HLS code

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

Co-authored-by: Brent R. Yates <brentRyates@gmail.com>
Co-authored-by: Thomas Schuh <thomas.schuh@stfc.ac.uk>

Update Settings.h (cms-sw#130)

Fix "storeTrackBuilderOutput_" typo

Update Setup.cc (cms-sw#129)

Change trackerDTC::Setup to tt::Setup . (Bug fix)

Update LayerEncoding.h (cms-sw#131)

* Update LayerEncoding.h

Add function to access layer corresponding to given DTC channel. (Needed by L1Trk Future CMSSW code).

* Update LayerEncoding.h

response to comment + fix to previous commit

* Update LayerEncoding.cc

Initialize data member numDTCsPerRegion_

* Update LayerEncoding.h

added comment

* Update LayerEncoding.h

clarified comment

Test vector fixes (cms-sw#132)

* Made eventProcessor a member of the producer.

* Output TC tables in the reduced config.

MP cleanup 220208 + MC fix (cms-sw#133)

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Some updates to MP to converge with HLS code

* Further clenup of the MP code

* More cleanup -removal of hardcoded numbers

* Further cleanup

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* fixing integer range check in FPGAWord.

* Fixing `zmatchcut_` for L1 and L2

* Undo the -0.06 in Settings.h as there is a cleaner fix to the overflows

* Slight rewerite to use <= instead < and not do subtracktion

* Some updates to MP to converge with HLS code

* Further clenup of the MP code

* More cleanup -removal of hardcoded numbers

* Further cleanup

* Fixes to the MC to allow full agreement with HLS

* Added a comment header and pipeline description

* Added comment about MC iterations

Co-authored-by: Thomas Schuh <thomas.schuh@stfc.ac.uk>
Co-authored-by: Anders <aryd@cern.ch>

customize L1FPGATrackProducer (cms-sw#112)

* track builder channel upgraded to assign stubs to channel.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* StreamsStub added as EDProduct of L1FPGATrackProducer

* code format.

* convert only finally accepted Tracklets to StreamsStub.

* undo last commit, adding trackword ed product and adding gaps to stubs and tracks to get clock accurate emulation.

* swap bugfix.

* rebased and name change of TrackBuilderChannel adopted.

* fixing rebase errors.

* fixing more rebase errors.

* fixing even more rebase errors.

* track builder channel upgraded to assign stubs to channel.

* renamed TrackBuilderChannel to ChannelAssignment now also containing DTC to IR mapping

* StreamsStub added as EDProduct of L1FPGATrackProducer

* rebased and name change of TrackBuilderChannel adopted.

* criteria to build track updated, TBout works now for all seed types.

* StreamsStub added as EDProduct of L1FPGATrackProducer

* use customize function to manipulate L1FPGATrackProducer configuration

* rebase to tschuh_SummerChain, customize updated to set EmulateTB, demonstrator counts now the amount of passed events.

* initial counter values fixed.

* rebase and reduce config customize function extended

* fixing merge errors.

* Ians first comments.

* rebase and Ians secodn comments.

* Update ChannelAssignment_cfi.py

* Ians third comments.

* Ians fourth comments.

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Update Customize_cff.py (cms-sw#135)

TBout analyzer (cms-sw#114)

* Reviewed.

* one merge error fixed, but a problem remains

* fixed second error.

* Update AnalyzerTBout.cc

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>

Fix d0 bias (cms-sw#124)

* Fix d0 bias

* Documented KF maths and variables

Ian tidy up (cms-sw#137)

* Added function to convert ATCA slot to DTC name

* Moved dtcname to Settings.h and put underscore at end of settings

* Declared functions const if dont change data members

* Added comments to clarify params overridden by python cfg

* Added comment

* Removed duplicate function TCNAme

disable truncation for displaced tracking (cms-sw#142)

DTC phi range hard-wired constants removed (cms-sw#141)

* Added function to get num ATCA slots

* Added comment

* Automatically calc DTC phi ranges

* Improved comments

* Added comment

* Simplified phi offset calc

* Fixed missing half-sector rotation bug

* Added comments

* Changed dtcphirange.txt to numbers instead of C++ code

Displaced tracking phi fix (cms-sw#147)

* usephiapprox on modify NtupleMaker cfg for grid jobs

* added displaced terms to phi calculation in TrackletCalculatorDisplaced

* reverting changes unrelated to phi correction

Jack hph (cms-sw#146)

* First Commit

* Code Format

* Fix Typo

* Naming Rule

* Chris' 2nd Comment

* Fixing Bug

* Ian's 1st Comments

* Ian's 2nd Comment: Remove SensorModule Class

* Ian's 3rd comment: Get rid of magic numbers

* Ian's 4th Comment: Add more clarification

* Code-check

Co-authored-by: Jack Li <jingyan.li@cern.ch>

Adding new features to ntuplemaker (cms-sw#148)

Co-authored-by: Jack Li <jingyan.li@cern.ch>

Update StubAssociation.cc (cms-sw#145)

as requested a separate PR.

Update github_CI.yml

Fixed incorrect comment

KFin emulator (cms-sw#143)

* initial commit.

* move ProducerTBout.cc from test to plugins

* KFin fully debugged.

* Producer TBout added to NTupleMaker

* chriss change to KFout

* Louises first comments.

* fixing rebase errors.

* KF reintegrated, stub residuals are not bit accurate yet.

* code format.

* added 1k ttbar@0PU events for internal kf maths tuning.

* Track builder r residual debug and KF digi function corrected.

* bug in z residual base fixed.

* Ians first comments.

* Ians secodn comments.

* recalculate z ressid from TTStubRefs, use TTStubRefs for seed stubs instead of fake stubs.

* Ians third comment.

* fixed comments TTDTC::Frames -> tt::Frames

* old stub uncertainty caclulation re-enabled.

* Ians 4th comments.

* code-checks.

* tilted stub z uncertainty fixed. not yet debugged against f/w.

* set max layers a kff adds to a track to 7 as we did in the past, no clue why it is 4 again ...

* agrrement with f/w, ready to merge.

Fix rare crash in KF (cms-sw#151)

* Fix rare crash in KF

* Fixed line break

Removed obsolete parameter. (cms-sw#152)

quick ntuple fix (cms-sw#153)

* L1TrackNtupleMaker_cfg.py updated reduced workflow.

* further cleaning.

Update L1TrackNtupleMaker_cfg.py

fixed typo

Removal of dependencies of ChannelAssignement (cms-sw#144)

* This code includes a new implementation of the Track and Stub Streams generation. The old code is still running in parallel.

* Remove code for old calculation of stream data - keeping the debug print out in this commit

* Remove debud printout

* added numSeedTypes function

* rebased Anders branch

* rebased Anders branch

* tidied up Anders branch

* tidied up Anders branch

* ran scram b code-format

* Thomas PR review comments

* max num of proj layers added to channel assignment.

* merge with Thomas commit

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Thomas Schuh <thomas.schuh@stfc.ac.uk>

Ran second auto formatter tool (cms-sw#154)

* Ran second auto formatter tool

* tweak

Update ProducerSetup_cfi.py

correct comment in code

Update Customize_cff.py

add comment in code

Tracklet Processor Displaced (cms-sw#159)

* Tracklet Processor Displaced

* code-format

* code-format again

* remove unnecessary comments and add explanation for header file

* implement more comments

* remove more magic numbers

Update track quality chi2 bins (cms-sw#161)

* update chi2 bins

* change chi2 variables to be per dof

Ian L1TStub bug fix (cms-sw#160)

* Ran second auto formatter tool

* tweak

* Fixed bug in L1TStub::isTilted function

* Update L1TrackNtupleMaker_cfg.py

Removed unnecessary line

* Update L1FPGATrackProducer.cc

Fix incorrect tiltedBarrel variable in endcap

rebase and scram b code-format

ran formatter tool 2

tweak

Update chi2 tq bins (cms-sw#165)

* change binning method used by track quality

* clean TrackQuality class to only create features used by default classifier

* ran scram b -j8 clang-format

Added tilted and endcap module ring no. to L1TStub (cms-sw#166)

* Added tilted and endcap module ring no. to L1TStub

* auto formatting

Fix stub order bug (cms-sw#164)

* fix to stub order bug

* fix to stub order bug

* Updated to one::EDAnalyzer

* ran scram b code format

* Fixed bug for combined modules

Update MatchCalculator.cc

Added comment.

rebase git conflict resolution

rebase git conflict resolution

rebase git conflict resolution

Remove obsolete FWCore functions (cms-sw#168)

Updated data/ files

tweak

Reduce L1 tracking CPU (cms-sw#172)

* Reduce CPU use

* Reduce CPU

* Reduce CPU

* Added track quality plots

* updated geom

* Trivial variable renames

* Moved RunTime call to constructor to save CPU

* Removed debug calcs from VarBase::calculate

* Optimised a bit more VarBase::calculate

* optimise CPU further

* auto format

Update L1TrackNtupleMaker.cc

Restored consumes<TrackingVertex>. Not required, but keeps CPU expensive loading of TrackingVertexCollection where it was to make CPU comparisons easier.

Removed CI .yml files & data/ directory to allow PR to central CMSSW
cmsbuild pushed a commit that referenced this pull request Nov 19, 2024
Squashed commit of the following:

commit c21a481
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Tue Nov 12 11:04:49 2024 -0800

    batch9 of updates for LST integration in CMSSW (#121)

    * FP16_Base compilation fixes
    * Delete obsolete comment
    * Remove duplicate enum
    * Remove unused arrays and functions
    * correct return type
    * Removed unnecessary CopyToDevice
    * Small fixes to address review comments
    * Simplify moving to common enum
    ---------

    Co-authored-by: Slava Krutelyov <slava77@cern.ch>
    Co-authored-by: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
    Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>

commit 1a0ab7e
Merge: 8928adf 036340d
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Nov 12 10:21:39 2024 -0800

    Merge tag 'CMSSW_14_2_X_2024-11-11-2300' into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles

commit 8928adf
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Thu Nov 7 05:30:25 2024 -0800

    Update LST workflows to use Run4 instead of 2026

commit bedeb45
Merge: 12ead85 476d3aa
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Nov 6 21:30:25 2024 -0800

    Merge remote-tracking branch 'SegLink/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles' into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_142X-11-06-1100

commit 476d3aa
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Mon Nov 4 06:02:24 2024 -0800

    batch8 of updates for LST integration in CMSSW (#113)

    * Removed allocBufWrapper and cache toggle
    * Removed references to temporaries
    * Fixed headers
    * Removed devAcc_
    * Simplified view creation
    * File and class renaming
    * Update workflow, enums, compilation flags
    * Move LSTOutputConverter to edm::stream::EDProducer
    * Merge standalone and CMSSW functions to get hits and TCs
    * Updates to remove syncs when creating or destroying the LSTEvent in CMSSW
    * Rename lst_INF and finalize simplification of compilation flags
    * Create lstProducerTask, move to C++20 pi and use C++20 in standalone compilation
    * Include numbers
    * Limit number of make threads

    ---------

    Co-authored-by: Andres Rios Tascon <ariostas@gmail.com>
    Co-authored-by: Manos Vourliotis <emmanouil.vourliotis@gmail.com>

commit 4d603ca
Merge: 04d02b4 b96fd02
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Oct 29 11:57:22 2024 -0700

    Merge tag 'CMSSW_14_2_0_pre3' into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles

commit 04d02b4
Merge: 83897c8 cb1557e
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Tue Oct 29 05:49:09 2024 -0700

    Merge pull request #109 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch7

    migrate to SoATemplate

commit cb1557e
Merge: 83897c8 f8e7884
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Mon Oct 28 15:06:13 2024 -0700

    Merge branch 'CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch7' into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles

commit f8e7884
Merge: ccc4bf4 48d01f3
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Mon Oct 28 14:35:23 2024 -0700

    Merge pull request #106 from SegmentLinking/more_soa_migrations

    continuing migration to SoA: update LS, migrate ranges, hits, endcap, modules

commit 48d01f3
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Oct 28 11:37:42 2024 -0700

    Review fixes

commit d08032a
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Oct 25 13:14:50 2024 -0700

    Consistency fixes

commit 891a97d
Merge: 043dfe0 ccc4bf4
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Oct 25 12:34:18 2024 -0700

    Merge branch 'CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch7' into more_soa_migrations

commit 043dfe0
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Oct 25 11:35:59 2024 -0700

    migrate modules to SoATemplate

commit ccc4bf4
Merge: cb84b9c 00013dd
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Oct 25 14:29:22 2024 -0400

    Merge pull request #104 from slava77/CMSSW_14_2_0_pre1/LSTb7-SoA-TC-T5

    continuing migration to SoA: upd TC, migrate T3s, T5s, pT3s and pT5s ...

commit 00013dd
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Oct 24 12:02:14 2024 -0700

    migrate pT3 and pT5 to SoATemplate

commit 5e2bf7b
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Oct 24 11:22:00 2024 -0700

    migrate EndcapGeometry to SoATemplate

commit 018204d
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Oct 24 11:18:59 2024 -0700

    migrate hits to SoATemplate

commit 534ac1b
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Oct 24 11:00:55 2024 -0700

    migrate ranges to SoATemplate

commit 9b8d26d
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Tue Oct 22 16:11:02 2024 -0700

    migrate quintuplets to SoATemplate

commit fd99b50
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Oct 22 08:35:15 2024 -0700

    Made view sizes clearer

commit 1bbe663
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Tue Oct 22 06:52:37 2024 -0700

    migrate triplets to SoATemplate

commit 6f1ea3f
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Oct 10 10:55:17 2024 -0700

    simplify a bit TC SoAs

commit cb84b9c
Merge: fc3fc6a 0e0b5e1
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Oct 18 07:26:37 2024 -0700

    Merge pull request #93 from SegmentLinking/segments_soa

    Migrate segments to SoA+PortableCollection

commit 0e0b5e1
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Oct 16 08:22:33 2024 -0700

    Match conventions from previous PRs

commit 6b37c07
Merge: efef777 fc3fc6a
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Oct 16 08:04:42 2024 -0700

    Merge branch 'CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch7' into segments_soa

commit fc3fc6a
Merge: 8338254 d3156d1
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Wed Oct 16 05:04:48 2024 -0700

    Merge pull request #101 from SegmentLinking/mds_soa

    Migrate MDs to SoA+PortableCollection

commit d3156d1
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Oct 15 20:11:11 2024 -0700

    Fixed formatting

commit 36a8c43
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Oct 14 13:51:19 2024 -0700

    Moved MiniDoubletsDeviceCollection definition

commit 3b4fa9e
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Oct 10 13:22:05 2024 -0700

    Made view sizes clearer

commit 66612e8
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Oct 10 12:48:15 2024 -0700

    Moved MD SoA definition to its own header

commit 129a2d4
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Oct 10 07:02:06 2024 -0700

    Adjusted naming convention

commit 8fba6cb
Merge: f430d1b 8338254
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Oct 10 06:48:51 2024 -0700

    Merge branch 'CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch7' into mds_soa

commit 8338254
Merge: 3858cf3 69804f0
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Oct 8 14:11:10 2024 -0400

    Merge pull request #90 from slava77/CMSSW_14_1_0_pre5/LSTb6-SoA-TCs

    migrate TrackCandidate to use SoATemplate and PortableCollection

commit 69804f0
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Fri Oct 4 16:04:19 2024 -0700

    move TrackCandidatesDeviceCollection and related aliases to interface/alpaka

commit f430d1b
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Oct 4 06:37:25 2024 -0700

    Formatted and removed unnecessary CopyToHost

commit efef777
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Oct 4 06:21:52 2024 -0700

    Removed unnecessary CopyToHost

commit a296da7
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Tue Oct 1 15:46:02 2024 -0700

    get rid of TrackCandidates* trackCandidatesD_ and simplify syntax

commit 52377d1
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Oct 1 08:33:37 2024 -0400

    Fixed makefile

commit 20f6f9c
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 30 17:11:03 2024 -0400

    Migrated MDs to SoA+PortableCollection

commit 155fc82
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 29 09:50:08 2024 -0700

    switch to TrackCandidates = ::lst::TrackCandidatesSoA::View

commit af1f68f
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 29 07:46:09 2024 -0700

    code checks

commit 8864fd1
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 29 07:42:03 2024 -0700

    sync DALPAKA flags in standalone builds with cmsdist scram-tools.file/tools/alpaka/alpaka.xml

commit a5822d0
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 29 07:41:06 2024 -0700

    add a check that device and host match for host=device

commit 3e98eb4
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Wed Aug 28 20:49:20 2024 -0700

    code checks

commit 18a1f6e
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Wed Aug 28 17:18:14 2024 -0700

    drop -Wshadow in standalone builds: DataFormats/SoATemplate and related generates around 30MB of warnings with only partial TrackCandidate SoA use

commit 94df11b
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Wed Aug 28 17:16:08 2024 -0700

    migrate TrackCandidate to SoA from DataFormats/SoATemplate: kernels internally are still using the POD TrackCandidates SoA (to be migrated later)

commit 96be4f7
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Sep 25 10:29:07 2024 -0700

    Initialize only required columns

commit 3858cf3
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 23 12:26:35 2024 -0700

    Fixed cxxopts compilation

commit 9e2a402
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 23 12:01:31 2024 -0700

    Format code

commit 77ff0e5
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 23 11:59:41 2024 -0700

    Fixed memset

commit 37fe122
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 23 11:44:35 2024 -0700

    Fixed indexing issues

commit acff43f
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Sep 20 08:30:54 2024 -0700

    Switched to only using views

commit a7e3ec3
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Sep 18 13:43:33 2024 -0700

    Fixed standalone compilation

commit d5da756
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Sep 18 12:44:07 2024 -0700

    Moved segments to SoA+PortableCollection

commit 83897c8
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 16 07:04:19 2024 -0700

    Updated setup script to CMSSW_14_2_0_pre1

commit 135e18b
Merge: 5f9c2f6 c312b85
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 16 07:01:32 2024 -0700

    Merge tag 'CMSSW_14_2_0_pre1' into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles

commit f68981e
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 16 06:57:59 2024 -0700

    Updated setup script to CMSSW_14_2_0_pre1

commit d764312
Merge: 5f9c2f6 c312b85
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Sep 16 06:52:36 2024 -0700

    Merge tag 'CMSSW_14_2_0_pre1' into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch7

commit 5f9c2f6
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Fri Sep 13 10:46:41 2024 -0700

    new style code-checks from cms-bot https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45117/41778/code-format.patch; the result looks less readable, but we have to comply

commit 2bc333b
Merge: ff27cf3 46f7f22
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Sep 13 09:13:42 2024 -0700

    Merge pull request #88 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch6

    Batch 6 for updates to LST integration in cms-sw

commit 46f7f22
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Sep 3 08:30:40 2024 -0700

    Finished cleaning namespaces

commit d2b9e89
Merge: f245be0 f0e560b
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Aug 30 15:18:33 2024 -0700

    Merge pull request #89 from SegmentLinking/more_review_fixes

    More review fixes: smart pointers, cleaner namespaces, naming fixes

commit f0e560b
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Aug 30 11:35:38 2024 -0700

    Renamed private data members

commit 3eb7a56
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Aug 30 11:03:29 2024 -0700

    Addressed review comments

commit 0340221
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Aug 30 10:42:33 2024 -0700

    Cleaned up namespaces

commit 1bff72d
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Aug 27 10:48:36 2024 -0700

    Started moving to smart pointers

commit f245be0
Merge: 9713499 24f587e
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Wed Aug 28 10:25:07 2024 -0700

    Merge pull request #85 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_smallFixesPostBatch5

    Small fixes post batch 5

commit 24f587e
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Aug 28 08:11:54 2024 -0700

    Invert DeltaPhi arguments in CMSSW to harmonize with standalone

commit b5a1383
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sun Aug 25 11:19:49 2024 -0700

    Harmonize pixelType determination in CMSSW with the standalone

commit bb8402d
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sun Aug 25 10:40:56 2024 -0700

    Addressing review comments on PixelType

commit 1b6a0e1
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Thu Aug 22 16:09:54 2024 -0700

    Apply review comments

commit 9713499
Merge: ff27cf3 3864e82
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Aug 21 18:52:16 2024 +0200

    Merge pull request #87 from slava77/CMSSW_14_1_0_pre5/LSTb6-alpaka-wait-bugfix

    bugfixes to incomplete alpaka::wait cleanup (for batch6)

commit c4d12fc
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Aug 21 03:04:50 2024 -0700

    Simplify consumes(), esConsumes(), produces() and code checks/format

commit 03da845
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Aug 21 02:45:29 2024 -0700

    Make a data member private

commit 3864e82
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Tue Aug 20 17:34:59 2024 -0700

    bugfixes to incomplete alpaka::wait cleanup: need to wait to get counters; need to write to CPU buffer asyncronously or directly only after a sync

commit fcb5e32
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Aug 20 11:45:11 2024 -0700

    Work on pixelType and removal of deprecated functions in standalone

commit 9544a58
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Aug 19 11:22:56 2024 -0700

    Revise some includes

commit ff27cf3
Merge: 77854d9 fe0d0ac
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Sat Aug 17 10:08:17 2024 -0700

    Merge pull request #79 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch5

    Batch 5 for updates to LST integration in cms-sw

commit fe0d0ac
Merge: fb5c0ea 79ea879
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Sat Aug 17 10:02:33 2024 -0700

    Merge pull request #84 from SegmentLinking/use_namespaces_instead_of_templates

    Moved LST and Event classes to ALPAKA_ACCELERATOR_NAMESPACE

commit 79ea879
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Sat Aug 17 07:31:46 2024 -0700

    Moved all alpaka code to ALPAKA_ACCELERATOR_NAMESPACE

commit 1a5e2c4
Merge: 9f6d612 fb5c0ea
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Sat Aug 17 05:27:27 2024 -0700

    Merge branch 'CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch5' into use_namespaces_instead_of_templates

commit fb5c0ea
Merge: 4ff4aaf 5cce69a
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Aug 16 15:08:14 2024 -0700

    Merge pull request #83 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_destructorsMovesKernelNames

    Remove user-defined destructors, make vector moves useful, rename kernels

commit 9f6d612
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Aug 16 12:55:26 2024 -0700

    Moved LST and Event classes to ALPAKA_ACCELERATOR_NAMESPACE

commit 5cce69a
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Aug 16 11:04:46 2024 -0700

    Code format and checks

commit 787dfe1
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Aug 16 10:38:02 2024 -0700

    Renaming of kernels

commit d5e443a
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Aug 16 09:33:38 2024 -0700

    Remove user-defined destructors

commit 8d2366b
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Aug 16 09:15:04 2024 -0700

    Remove pass by const reference when std::move-ing

commit 4ff4aaf
Merge: c1767fa 7889093
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Aug 16 13:13:52 2024 -0400

    Merge pull request #77 from slava77/CMSSW_14_1_0_pre5/LSTb5-alpaka-calls-review

    batch5: alpaka::wait and use views to local host data instead of buffers

commit 7889093
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 15 16:43:14 2024 -0700

    add synchronizations in callers of the event methods where it matters; make synchronization more explicit/flexible in names or function arguments

commit c1767fa
Merge: d3549cb 22192ec
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Wed Aug 14 15:49:57 2024 -0700

    Merge pull request #82 from SegmentLinking/more_review_fixes

    More review fixes

commit 43ce20e
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Mon Aug 12 15:26:08 2024 -0700

    explicitly require 1D single block kernels to use Acc1D and have one block with asserts

commit 22192ec
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Aug 12 12:19:53 2024 -0700

    Add include for fp16 on HIP

commit a0432cc
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Aug 12 12:09:26 2024 -0700

    Reduce number of moduleConnections_ lookups

commit 80ffdc3
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Aug 12 11:51:40 2024 -0700

    Changed syntax of atomic operations

commit c6a2468
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 8 15:35:06 2024 -0700

    lst::createWorkDiv now depends on Acc to avoid ODR; allocBufWrapper correct parameter is TDev

commit a7d73c0
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 8 06:37:00 2024 -0700

    replace alpaka::getPtrNative(buf) with buf.data()

commit 4ef678d
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 8 06:21:53 2024 -0700

    switch to using alpaka::exec

commit 7343156
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Aug 8 05:31:06 2024 -0700

    cleanup unnecessary alpaka::wait; add comments justifying other alpaka::wait calls; switch to cms::alpakatools::make_host_buffer for a few local buffers

commit e8cc7a8
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Fri Aug 2 16:20:25 2024 -0700

    cleanup unnecessary alpaka::wait

commit 8557644
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Fri Aug 2 08:16:42 2024 -0700

    remove spurious semicolons at the end of method implementations

commit d3549cb
Merge: 77854d9 8f720ad
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Mon Aug 5 14:33:06 2024 -0700

    Merge pull request #76 from SegmentLinking/LSTESData_fixes

    LSTESData fixes

commit 8f720ad
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Aug 5 07:57:46 2024 -0700

    Fixed memcpy

commit 77854d9
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Aug 2 16:13:09 2024 -0700

    name=1 -> name=RecoTracker/LSTCore

commit 4cd5974
Merge: 1d9b396 ecd8e3e
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Aug 2 13:42:50 2024 -0700

    Merge pull request #66 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch4

    Batch 4 for updates to LST integration in cms-sw

commit 14b8bd9
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Aug 2 08:36:24 2024 -0700

    Minor cleanup

commit 0bcb06c
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Jul 31 14:00:24 2024 -0700

    Removed alpaka functions from host ES code

commit ecd8e3e
Merge: d7689bb a076afb
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Wed Jul 31 11:11:06 2024 -0700

    Merge pull request #72 from SegmentLinking/removalOfSDL

    Total removal of sdl/SDL

commit d7689bb
Merge: 24aa3a2 5b1e21c
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Wed Jul 31 07:09:00 2024 -0700

    Merge pull request #73 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_fixWorkflowConflict2

    Resolving latest workflow conflict

commit 5b1e21c
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Jul 31 02:50:16 2024 -0700

    Fix workflow conflict

commit a076afb
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Jul 31 01:30:09 2024 -0700

    Remove forgotten flag

commit c3f41a7
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 11:26:35 2024 -0700

    Code checks and format

commit 67c2376
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 10:57:10 2024 -0700

    Simplification of variable naming

commit d378a59
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 10:33:43 2024 -0700

    Removal of sdl/SDL from all standalone code

commit 24aa3a2
Merge: 3fc9904 944e1b4
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Tue Jul 30 08:34:03 2024 -0700

    Merge pull request #71 from SegmentLinking/renameClassesRemoveCopies

    More work on Constants and removal of vector copies

commit 961d01e
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 07:53:28 2024 -0700

    Remove sdl from variable names

commit 944e1b4
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 07:27:10 2024 -0700

    Code checks and format

commit 5d5bd29
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 05:37:34 2024 -0700

    Split PixelTriplets to PixelQuintuplets

commit ae851e0
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 05:27:15 2024 -0700

    Fourth batch of fixing function arguments

commit 3fc9904
Merge: fac2958 d5e0b69
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 13:46:03 2024 +0300

    Merge pull request #70 from slava77/CMSSW_14_1_0_pre5/LSTb4-buf-lite

    alpaka modernise/improve for batch4

commit 954a22a
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 30 03:31:08 2024 -0700

    Third batch of fixing function arguments

commit 2af0685
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Jul 29 08:01:16 2024 -0700

    Second batch of fixing function arguments

commit ce79bc1
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Jul 29 06:03:10 2024 -0700

    First batch of fixing function arguments

commit 96aa7c0
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sat Jul 27 17:11:01 2024 -0700

    Revert constness on arguments passed by value

commit e076050
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sat Jul 27 14:51:16 2024 -0700

    Revert moving general purpose functions to common CMSSW file

commit 9268f49
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Jul 26 06:27:32 2024 -0700

    More constness, removal of vector copies, and movement of general-purpose alpaka functions

commit d5e0b69
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Wed Jul 24 16:12:31 2024 -0700

    remove Vec3D createVec

commit 07e0f40
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Wed Jul 24 15:55:20 2024 -0700

    geometry ::get single search

commit 77e6b9a
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Jul 24 09:44:52 2024 -0700

    Removal of vector copies, as per comments

commit 375a06c
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Jul 24 06:45:27 2024 -0700

    Renaming of constants and removal of custom functions now implemented in alpaka

commit 69debc2
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Tue Jul 23 15:58:55 2024 -0700

    use cms::alpakatools::once_per_block

commit fac2958
Merge: ff12237 7fdcabd
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Mon Jul 22 14:27:41 2024 -0700

    Merge pull request #68 from SegmentLinking/renameClassesRemoveCopies

    Renaming of namespaces/classes/macros and removal of vector, etc. copies

commit 7fdcabd
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Jul 22 10:06:11 2024 -0700

    Renaming of classes/structs/macros/constants

commit a22faeb
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sun Jul 21 14:34:26 2024 -0700

    Revert change in TrackListMerger

commit 304929e
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sun Jul 21 14:25:50 2024 -0700

    Fixes after rebase

commit e54c6f1
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sat Jul 20 08:04:57 2024 -0700

    Apply comments namespace and type renaming

commit 1a6e27b
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sat Jul 20 07:42:27 2024 -0700

    Fix for wrong loop range in pT3 kernel

commit 5d0ef1e
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Jul 19 09:44:07 2024 -0700

    Namespace renaming SDL->lst and inclusion of the T5DNN->t5dnn namespace under it

commit ff12237
Merge: 1250a8c d0e320a
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Jul 19 19:50:11 2024 -0400

    Merge pull request #67 from slava77/CMSSW_14_1_0_pre5/LSTb4-buf-base

    remove inheritance of buffers on underlying SoAs

commit d0e320a
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Fri Jul 19 08:56:04 2024 -0700

    remove inheritance of buffers on underlying SoAs

commit 1fb0489
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Fri Jul 19 08:55:13 2024 -0700

    split ranges from modules

commit 1250a8c
Merge: 1d9b396 fb12af0
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Thu Jul 18 14:34:11 2024 -0700

    Merge pull request #65 from SegmentLinking/use_common_library

    Move some things out into a common library

commit fb12af0
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Jul 18 07:44:57 2024 -0700

    Format code

commit d33ac32
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Thu Jul 18 07:28:52 2024 -0700

    A bit more cleanup

commit ccd29f4
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Jul 17 11:17:35 2024 -0700

    Format and cleanup

commit c4ac510
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Jul 17 11:10:51 2024 -0700

    Fixed standalone compilation

commit 64a7bf1
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Jul 17 10:41:54 2024 -0700

    Moved more things out of the alpaka directory

commit 9fd3355
Author: Andres Rios-Tascon <ariostas@gmail.com>
Date:   Mon Jul 15 11:28:07 2024 -0400

    Use pre-defined alpaka types

commit 9c87a88
Author: Andres Rios-Tascon <ariostas@gmail.com>
Date:   Thu Jul 11 13:04:39 2024 -0400

    Moved some things out into a common library

commit 1d9b396
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Jul 16 11:25:54 2024 -0700

    Updated setup scripts to use CMSSW 14_1_0_pre5

commit 23ec786
Merge: 7187927 b20c7aa
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Jul 16 11:17:08 2024 -0700

    Merge tag 'CMSSW_14_1_0_pre5' into CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles

commit 7187927
Merge: 4cd8924 34c56c6
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Wed Jul 10 15:55:04 2024 -0700

    Merge pull request #50 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch3

    Batch 3 for updates to LST integration in cms-sw

commit 34c56c6
Merge: ae67290 86503a2
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Tue Jul 9 16:29:56 2024 -0700

    Merge pull request #49 from SegmentLinking/ESProducer_fixes

    ESProducer fixes

commit ae67290
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 9 06:07:31 2024 -0700

    Simplify LST workflows

commit 7cfe3a5
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 9 06:06:39 2024 -0700

    Code format and checks

commit a3a8054
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jul 9 05:19:42 2024 -0700

    Even further work on naming values and sqrt, loop, etc. simplifications

commit 86503a2
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Jul 8 07:41:35 2024 -0700

    Fixed include guards for headers in interface directory

commit f47212f
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Jul 8 07:32:46 2024 -0700

    Renamed new endcap geometry class

commit d3e5999
Merge: f46b6cb c563eb0
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Jul 8 08:07:27 2024 -0700

    Merge remote-tracking branch 'SegLink/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch3' into ESProducer_fixes

commit c563eb0
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Jul 8 07:39:49 2024 -0700

    Further work on naming values and sqrt, loop, etc. simplifications

commit 4d7e54a
Merge: a97714a dc13ac5
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Jul 5 09:15:23 2024 -0700

    Merge pull request #58 from SegmentLinking/remove_LST_IS_CMSSW_PACKAGE

    combo of: Remove LST_IS_CMSSW_PACKAGE (#47), configurable dup cleaning (#37), typo in T3 code (#44)

commit a97714a
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Jul 3 07:16:19 2024 -0700

    Apply reco comments: Naming values and sqrt, loop, etc. simplifications

commit 236ad8c
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Sat Jun 29 02:43:48 2024 -0700

    Simplification of sqrt operations for pT3s

commit 149c628
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Jun 28 21:23:31 2024 +0200

    Resolve conflicts regarding workflows

commit f46b6cb
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Jun 24 12:52:12 2024 -0700

    Removed -Wshadow flag

commit eb5de05
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Jun 24 11:30:45 2024 -0700

    Minor cleanup

commit a3f65da
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Mon Jun 24 11:00:13 2024 -0700

    Separated EndcapGeometry into host-only and buffers struct

commit ef48f74
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Jun 24 02:21:11 2024 -0700

    Removal of gpu modifier from LST workflows

commit e0acfa5
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Tue Jun 18 10:40:38 2024 -0700

    Addressed ESProducer comments

commit 4cd8924
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Fri Jun 14 18:00:59 2024 -0700

    code-format/checks

commit e64c2cc
Merge: 314e95d 3552ad3
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Fri Jun 14 17:45:17 2024 -0700

    Merge pull request #38 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch2

    Batch 2 for updates to LST integration in cms-sw

commit dc13ac5
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri Jun 14 16:53:31 2024 -0400

    Removed LST_IS_CMSSW_PACKAGE flag

commit 14af981
Merge: f555485 f4bd702
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Thu Jun 13 14:18:35 2024 -0700

    Merge pull request #44 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_TrackLooperPR407

    Fix typo in T3 code

commit 3552ad3
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Thu Jun 13 09:42:00 2024 -0700

    Fixing CMS coding rule 1

commit f4bd702
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Jun 12 06:28:40 2024 -0700

    Fix typo in T3 code

commit 944652f
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Tue Jun 11 01:17:16 2024 +0200

    Keep comment closer to the added task object

    Co-authored-by: Slava Krutelyov <slava77@gmail.com>

commit f555485
Merge: 314e95d 0829926
Author: Slava Krutelyov <slava77@gmail.com>
Date:   Mon Jun 10 14:41:22 2024 -0700

    Merge pull request #37 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_TrackLooperPR408

    Make compilation flags for duplicate cleaning and triplet pLSs into runtime flags (TrackLooper PR#408 + cmssw PR#31)

commit 85682e8
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Jun 10 09:08:42 2024 -0700

    Resolving PR comments LST folder

commit 0829926
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Jun 7 18:36:46 2024 -0700

    Code checks and format

commit 4747b41
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Fri Jun 7 16:53:38 2024 -0700

    Make compilation flags for duplicate cleaning and triplet pLSs into runtime flags (TrackLooper PR#408 + cmssw PR#31)

commit 314e95d
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Thu Jun 6 16:51:30 2024 -0700

    code-format

commit 9f697fd
Author: Slava Krutelyov <slava77@cern.ch>
Date:   Wed Jun 5 16:39:31 2024 -0700

    put lstModulesDevESProducer on a dummy visible task to bypass the module creation

commit e9733d4
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Thu Jun 6 14:58:08 2024 -0700

    Remove outdated files

commit f1dee27
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Jun 5 09:33:05 2024 -0400

    Truncate git logs to 100 commits

commit ee1e94e
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Wed Jun 5 09:32:32 2024 -0400

    Fixed standalone build

commit 0edc116
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Wed Jun 5 15:00:16 2024 -0700

    Update directory for LST data files

commit 7c6bcfa
Author: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Date:   Mon Jun 3 10:16:56 2024 -0700

    Add two-iteration,tracking-only LST workflows, both on CPU and GPU

commit 7bc53be
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri May 31 14:21:58 2024 -0400

    Added RecoTracker/LST package

    Co-authored-by: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
    Co-authored-by: Slava Krutelyov <slava77@gmail.com>

commit 0cf5c03
Author: Andres Rios Tascon <ariostas@gmail.com>
Date:   Fri May 31 14:19:46 2024 -0400

    Added RecoTracker/LSTCore package

    Co-authored-by: Tres Reid <tres.reid@gmail.com>
    Co-authored-by: Philip Chang <philip@ucsd.edu>
    Co-authored-by: Gavin Niendorf <gavinniendorf@gmail.com>
    Co-authored-by: YonsiG <yag002@ucsd.edu>
    Co-authored-by: Balaji Sathia Narayanan <balajivenkat96@gmail.com>
    Co-authored-by: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
    Co-authored-by: Slava Krutelyov <slava77@gmail.com>
    Co-authored-by: Jonathan Guiang <jguiang@ucsd.edu>
    Co-authored-by: Bei Wang <beiwang@princeton.edu>

Co-authored-by: Tres Reid <tres.reid@gmail.com>
Co-authored-by: Philip Chang <philip@ucsd.edu>
Co-authored-by: Gavin Niendorf <gavinniendorf@gmail.com>
Co-authored-by: YonsiG <yag002@ucsd.edu>
Co-authored-by: Balaji Sathia Narayanan <balajivenkat96@gmail.com>
Co-authored-by: Manos Vourliotis <emmanouil.vourliotis@gmail.com>
Co-authored-by: Slava Krutelyov <slava77@gmail.com>
Co-authored-by: Jonathan Guiang <jguiang@ucsd.edu>
Co-authored-by: Bei Wang <beiwang@princeton.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants