Applying latest ROOT commits to branch V6-26-00-patches #184
Conversation
Previously depending whether the TTreeCache was globally enabled or disabled and whether fAutoFlush was set or not, the TTreeCache would be enabled or not. In particular no longer rely on TTree::Streamer setting fCacheSize to an estimated value when the TTreeCache is disabled globally (The old code lead to the cache being enabled even-though it was disabled). Note/Reminder: `TTreePlayer::Process` (and hence `TTree::Draw`) does not rely on the global setting on whether the cache should be used or not and only respect an explicit disabling of the cache for the specific `TTree` being used.
Prior to this change, the cache of which basket to start the search
on would restart from the first basket at each cluster iteration
(i.e. for filling the cache with with clusters)
On an extreme example:
15,272,928 entries
152,739 baskets (and as many clusters)
10,000 Actual TTreeCache buffer size (minimum allowed)
8,442 estimated buffer size of TTreeCache (1.5 times compressed buffer size)
400 bytes per baskets
100 entries per baskets (i.e. per clusters)
25 number of cluster per TTreeCache buffer for single branch with default size.
1 float per entry (reading a single branch).
This ends up repairing the performance of a simple `TTree::Draw` of a single branch
from 1 hour back down to 7s (performance seem in v6.12).
This correct an issue introduced by commit 73f6223 first since in v6.14/00
This fixes #12649
…ket.
On an extreme example:
15,272,928 entries
152,739 baskets (and as many clusters)
10,000 Actual TTreeCache buffer size (minimum allowed)
8,442 estimated buffer size of TTreeCache (1.5 times compressed buffer size)
400 bytes per baskets
100 entries per baskets (i.e. per clusters)
25 number of cluster per TTreeCache buffer for single branch with default size.
1 float per entry (reading a single branch).
we gain 20% run time on a call to `Tree::Draw`
There can be multiple attributes in the forward declaration, see the added test in roottest/cling/dict/enum (reduced from a case reported by CMS in cms-sw/cmssw#42234), so we have to look for the last closing parentheses. (cherry picked from commit 9d2f761)
aandvalenzuela
changed the title
|
A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch cms/v6-26-00-patches/2f336483c6. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
|
why this PR @aandvalenzuela ? |
|
I created the branch |
|
did our normal proceedure to update root not work for this? I mean running https://github.com/cms-sw/cms-bot/blob/master/cmsdist-tool-update.sh for IB/CMSSW_13_3_X/master ? |
|
I am deleting cms/v6-26-00-patches/2f336483c6 branch now and please use the cmsdist-tool-update.sh for updating |
|
It was creating a |
|
Okay, let me retry! Thanks |
you might have used wrong cmsdist branch. if you have used |
|
You are right, sorry for the noise! |
No description provided.