[tree] Change return type of TBranch::GetAddress() et al to void*
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the `TBranch::GetAddress` method returned a `char *`. This causes incompatibility with PyROOT, because `char *` is automatically converted to a Python string, which is the wrong thing to for an address. This made the return value unusable in PyROOT. That's a bug that currently prevents us from reimplementing some pythonizations in native Python. Therefore, the return type of `TBranch::GetAddress()` was changed to `void *` in this release. Even if this change is not backwards compatible for typing reasons, the returned value is the same. With this change, the code is also more consistent because `GetAddress()` and `SetBranchAddress()` use the same type for the address.
|
please test for CMSSW_14_0_ROOT6_X |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/953770d5da. @cmsbuild, @iarspider, @aandvalenzuela, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30df6f/37053/summary.html Comparison SummarySummary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the
TBranch::GetAddressmethod returned achar *. This causes incompatibility with PyROOT, becausechar *is automatically converted to a Python string, which is the wrong thing to for an address.This made the return value unusable in PyROOT. That's a bug that currently prevents us from reimplementing some pythonizations in native Python.
Therefore, the return type of
TBranch::GetAddress()was changed tovoid *in this release. Even if this change is not backwards compatible for typing reasons, the returned value is the same.With this change, the code is also more consistent because
GetAddress()andSetBranchAddress()use the same type for the address.