-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding validation tool (KS test) #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandrosov
requested changes
Oct 27, 2020
kandrosov
reviewed
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lguzzi! The current version code looks good. To close this PR, could you please:
- Post here timing to run the tool on a relatively large dataset (at least O(10 GB)) for the future references.
- Add instructions on how to run the validation into README.md
kandrosov
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add the vaidation tool. The script loads a list of files into a RDataFrame, splits the dataframe into different chunks and then runs a Kolmogorov-Smirnov test between the first chunk and the rest to check the compatibility of some distributions.
The distributions considered for the KS test are:
The script creates a root file storing the chunk histograms, a json file with the p-values and the pdf files of the KS comparison.
You can find and example at /afs/cern.ch/user/l/lguzzi/public/TauPOG/validation_tool_test (run on /eos/cms/store/group/phys_tau/TauML/prod_2018_v1/full_tuples/WJetsToLNu_HT-2500ToInf/eventTuple_1-1.root)
Time tests
Here are some timing test I run on an lxplus machine:
Run time after a fresh login (subsequent calls are about twice as fast):
1 thread: 106 s
4 thread: 47 s
10 thread: 19 s
The most time consuming function is load_histograms, which takes about 7s per call running on one thread, 2s per call running on four threads and 1s per call on ten threads (13 calls in total).