Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix and addition of new training options for BDT readout #43

Conversation

anehrkor
Copy link

@anehrkor anehrkor commented Apr 6, 2017

This PR fixes a bug where the decay mode 11 (3-prong+1Pi0) was not considered when reading the BDT output.

Moreover, new training options are added to the read out for upcoming trainings that include the Gottfried-Jackson angle as a variable, and no longer use the leading track chi2.

anehrkor added 2 commits April 6, 2017 11:40
…eading out BDT value for new decay modes

- Addition of read out for new training options: these include the Gottfried-Jackson angle and remove the leading track chi2, which has no discrimination power
@roger-wolf
Copy link

Hi Alex,
this is for future MVA trainings? How much are current trainings touched by this? E.g. I would have expected a switch at cfg level that indicates whether to choose or not to choose the GJ-angle as a variable in the readout of the MVA. Or is it recognized automatically that for a given training this variable is not contained?

Also the bugfix: does this have an impact on the r/o of current MVA trainings?

Cheers,
Roger

@anehrkor
Copy link
Author

anehrkor commented Apr 7, 2017

Hi Roger,

current trainings are not touched by this at all since the user needs to decide which MVA option to use in his/her config file (see for example here).
Currently, no sqlite file with working points for the new variable has been uploaded to CondDB.

The bug fix has no impact on any trainings performed so far. It is however relevant for upcoming trainings with new MC, as the new tau decay mode is reconstructed from CMSSW 8_1_X onwards.

Cheers,
Alex

@roger-wolf roger-wolf merged commit 5748327 into cms-tau-pog:CMSSW_9_1_X_tau-pog_tauID-GJangle Apr 20, 2017
roger-wolf pushed a commit that referenced this pull request Nov 17, 2017
mbluj pushed a commit that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants