Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xeno tunnels and eggs are not converted to forsaken #4376

Closed
3 tasks done
private-tristan opened this issue Sep 9, 2023 · 3 comments · Fixed by #5394
Closed
3 tasks done

xeno tunnels and eggs are not converted to forsaken #4376

private-tristan opened this issue Sep 9, 2023 · 3 comments · Fixed by #5394
Labels
Confirmed Bug We have the same at home!

Comments

@private-tristan
Copy link
Contributor

private-tristan commented Sep 9, 2023 •
edited
Loading

Testmerges

happened a while ago, and haven't played forsaken since, so i have no TMs to list.

Description of the bug

play forsaken xeno
attempt to use tunnel
instead prompts you to destroy the tunnel (which fails because you're a drone)

What's the difference with what should have happened?

play forsaken xeno
attempt to use tunnel
enter tunnel

How do we reproduce this bug?

  1. make tunnels/on a map with tunnels roundstart
  2. launch alamo to turn all xeno weeds into forsaken weeds
  3. spawn as forsaken xeno
  4. try to use tunnel
  5. cry
    ...

Issue Bingo
@private-tristan private-tristan added the Bug Admin events aren't bugs label Sep 9, 2023
@TeDGamer
Copy link
Contributor

Eggs and larva ( in infected poeple) as well aren't changed to forsaken.

@private-tristan private-tristan changed the title xeno tunnels are not converted to forsaken xeno tunnels and eggs are not converted to forsaken Sep 20, 2023
@private-tristan
Copy link
Contributor Author

Actually, those who are infected BEFORE hijack on the ground are properly converted to forsaken, but any new hugs using eggs already planted (at hive or around the map from hugger traps/eggsac eggs) will give base hive huggers.
The only way to get forsaken huggers is to make a egg morpher and fill it.

@Huffie56
Copy link
Contributor

Huffie56 commented Oct 1, 2023

the conversion as been first introduce by this PR so it's a good start if someone want to fix it i guess...
#3685

@Huffie56 Huffie56 added Confirmed Bug We have the same at home! and removed Bug Admin events aren't bugs labels Dec 9, 2023
@private-tristan private-tristan mentioned this issue Dec 31, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 31, 2023
@private-tristan
Eggs are now properly converted to forsaken on evac (#5340)
192e412 
# About the pull request
half of #4376 
eggs now become forsaken on hijack, like everything else. tested and it
works.


# Explain why it's good for the game

bugs should be fixed


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl: Private Tristan
fix: Eggs are properly converted to Forsaken hive on evac
/:cl:
@private-tristan private-tristan mentioned this issue Jan 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2024
@private-tristan
Tunnels are converted to forsaken on evac (#5394)
5525c2b 
# About the pull request
the other half of #5340, fixes #4376 
Tunnels are now forsaken!
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game

Forsaken xenos should be able to use tunnels

# Testing Photographs and Procedure
<details>
<summary>Open me for testing</summary>


https://github.com/cmss13-devs/cmss13/assets/54422837/25f7ce72-0773-4bce-896a-800054d6b232



https://github.com/cmss13-devs/cmss13/assets/54422837/e4954940-f39e-4bda-9756-5f8da3dcc6a0



</details>


# Changelog
:cl:
fix: Tunnels are now converted to forsaken on evac.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tunnels are converted to forsaken on evac private-tristan/cmss13
3 participants
@private-tristan @TeDGamer @Huffie56