Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin 'Medals-Panel' broken. #5768

Closed
3 tasks done
dadlips opened this issue Feb 21, 2024 · 1 comment · Fixed by #5764
Closed
3 tasks done

Admin 'Medals-Panel' broken. #5768

dadlips opened this issue Feb 21, 2024 · 1 comment · Fixed by #5764
Labels
Bug Admin events aren't bugs

Comments

@dadlips
Copy link

dadlips commented Feb 21, 2024

Testmerges

N/A

Round ID

20976

Description of the bug

occurred at 002B:C562F1B7 in TGUI.The current application will be terminated.Send the copy of the following stack trace to an authorizedWeyland-Yutani incident handler at https://github.com/cmss13-devs/cmss13/issues.Thank you for your cooperation.
Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at Ts (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:116883)
at g (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:60966)
at jl (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:72975)
at kc (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:121892)
at vs (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:109311)
at xs (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:109245)
at ps (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:109108)
at ls (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:106225)
at Wi (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:46865)
at ts (http://cdn.cm-ss13.com/live/ed/asset.ed1547734b51361ecc42b8d86f8efd62.js:1:103309)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
State: {"ckey":"smellyhippie","interface":"MedalsPanel","window":{"key":"[0x21000c4a]-main","size":null,"fancy":1,"locked":0}}

Weyland-Yutani (c) 2100-2182 Building better user interfaces.

image

What's the difference with what should have happened?

see above.

How do we reproduce this bug?

  1. Type Medals-Panel into your console to open the admin Medals-Panel
  2. it crashes.

Issue Bingo

@dadlips dadlips added the Bug Admin events aren't bugs label Feb 21, 2024
@harryob
Copy link
Member

harryob commented Feb 21, 2024

this'll be fixed by #5764

github-merge-queue bot pushed a commit that referenced this issue Feb 21, 2024
# About the pull request

This PR is a follow up to #5493 fixing the Medals Panel. Some reason
Fragment is busted if you don't use a key?

# Explain why it's good for the game

Fixes 

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/c811b7ef-c9b5-45e3-b95b-bad416e8ab7a)

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/41a05979-eda5-4a1f-ae7d-1f8ddaf50129)

</details>


# Changelog
:cl: Drathek
ui: Fix broken admin Medals Panel
/:cl:

fixes #5768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants